Commit Graph

6119 Commits

Author SHA1 Message Date
8d92a8df68 refactor: On windows use the old malloc method to prevent random test failure in IKeyState 2025-08-12 12:14:21 -04:00
d6b53ea718 fix: failures in big endian machines tests 2025-08-12 16:56:17 +01:00
64dc2299da docs: expand user configuration documentation 2025-08-11 17:59:40 +01:00
2e193c6a78 chore: PortalInputCapture, conform to naming conventions 2025-08-11 12:58:52 -04:00
f95230549a chore: EiScreen: conform to nameing conventions 2025-08-11 12:58:52 -04:00
a13803df94 chore: EiKeyState, conform to naming conventions 2025-08-11 12:58:52 -04:00
2ba7fb2f05 chore: EiEventQueueBuffer, conform to naming conventions 2025-08-11 12:58:52 -04:00
9442295227 chore: remove unused HYPER key 2025-08-11 12:32:50 -04:00
8d87f3250d refactor: ScreenSettingsDialog use qDeleteAll to clear list of items on alias remove 2025-08-11 12:32:50 -04:00
e700867a32 refactor: remove ServerConfig remove const qualifer from QString return 2025-08-11 12:32:50 -04:00
a21d48defb refactor: reorder initilization order in XWindowEventQueueBuffer constructor 2025-08-11 12:32:50 -04:00
3770e2c39e chore: XWindowsScreen::handleSystemEvent, remove unused Window variables 2025-08-11 12:32:50 -04:00
8d90515446 chore: define var on seperate line from type 2025-08-11 12:32:50 -04:00
db67550db3 refactor: server: use contains when possible 2025-08-11 12:32:50 -04:00
85e7d95188 refactor: server/Config use contains 2025-08-11 12:32:50 -04:00
651e093e04 refactor: clientProxy1_4 do not create pointless override that just call the baseclass 2025-08-11 12:32:50 -04:00
02fb9915bf refactor: Arch, only define init override on windows, where its ambiguious 2025-08-11 12:32:50 -04:00
6153f64fb7 chore: remove uneeded casts 2025-08-11 12:32:50 -04:00
f91df1639b refactor: make sure to state type of access to base class 2025-08-11 12:32:50 -04:00
63bd2e71b0 refactor: CoreProcess fully qualify enums used in signals 2025-08-11 12:32:50 -04:00
e1d00d59a4 refactor: ScreenSetupModel::isFull compaire same type of iterator 2025-08-11 12:32:50 -04:00
5def3f1f6a refactor: DaemonApp add context object for lambda starting the thread
chore: DaemonApp, remove unnessary QObject:: for connect calls
2025-08-11 12:32:50 -04:00
6840e1e7eb fix: Better description for InvalidProtocolException
fixes: #8830
2025-08-11 17:14:45 +01:00
85d89f9846 refactor: XArch Classes => Arch Exception Classes 2025-08-11 17:14:45 +01:00
8929f85bf7 refactor: XConfigRead => ServerConfigReadException 2025-08-11 17:14:45 +01:00
9601180e1b refactor: XBase Classes => BaseException 2025-08-11 17:14:45 +01:00
64786ddcb7 refactor: XDeskflow Classes => DeskflowException Classes 2025-08-11 17:14:45 +01:00
e4a9d1eb78 refactor: XScreen Classes => ScreenException Classes 2025-08-11 17:14:45 +01:00
1b04b1137c refactor: XIO Classes => IOException Classes 2025-08-11 17:14:45 +01:00
813b0c3828 refactor: mt/XThread Classes => mt/ThreadException Classes 2025-08-11 17:14:45 +01:00
22a358fb49 refactor: XMT Classes => MTException Classes 2025-08-11 17:14:45 +01:00
ada2813f9f refactor: XSocket Classes => XSocketException Classes 2025-08-11 17:14:45 +01:00
906c07e4fd fix: MainWindow::setHostName only check if the screen is existing when in server mode, In severmode update the serverConfig serverName to prevent a case where the server screen is on the grid with the old name breaking the layout 2025-08-11 16:49:25 +01:00
a4c0e30bb8 fix: Ignore Mod2 and Mod3 to make log quieter 2025-08-07 15:31:52 -04:00
a5c9744258 fix: Account for more modifiers in the EI keymap calculation
Some modifiers, notably LevelThree, were not accounted for in the
modifier mask calculation. This leads to an incorrect keymap where some
key symbols were listed for keys without (or insufficient) modifiers.
Emulating those keys can then produce the wrong keysyms.

Reproducible with server and client on English(UK) layout and typing
e.g. [. That key has its own key AD11 (right of P) but is also on
the third level of AE08 (the 8 key). When the server sends the keyid 91
(for [) the client looks it up in the pre-generated keymap. It is found
first on the 8 key with no modifiers (because LevelThree was previously
ignored), hence the client simulates a key 8 press without modifiers.
This erroneously produced an 8 instead of the wanted [.

Fix this by ensuring that all modifiers are accounted for in the key
map. This fix is likely incomplete as it does not account for the full
virtual modifier to real modifier mappings possible (e.g. Mod5 *may* be
something other than AltGr) but it does push the can a bit further down
the road, for someone else to release the worms.

Closes: #8168
2025-08-07 15:31:52 -04:00
a8bf217e62 ci: Rename job 'reuse-lint' to 'lint-reuse' for consistency 2025-08-06 23:29:56 +01:00
fff25b4144 ci: Rename lint-check action to lint-clang 2025-08-06 23:29:56 +01:00
82ba5a4b97 ci: Remove redundant markdown header 2025-08-06 23:29:56 +01:00
436f5b7f0a ci: Fix naming conventions for step names and bash vars 2025-08-06 23:29:56 +01:00
cf1789545a ci: Surface lint and test results to comment
It's a bit annoying how you have to go to the workflow result to see the lint error and test results. This surfaces it to the comment in the PR.
2025-08-06 23:29:56 +01:00
d7f882f0c4 ci: Include clang-format version in lint summary
This could help confused developers understand why their clang-format is working differently to CI
2025-08-06 23:29:56 +01:00
2a84ef0ebf refactor: update log calls to LOG_... fixes #8819 2025-08-06 16:18:38 +01:00
4f644acbca ci: Use cat directly when printing PR comments
Wrapping in echo was stripping newlines.
2025-08-06 10:47:13 -04:00
9a9bd7e262 chore: Improve logging for active sides
For the longest time, this log line has bugged me:
```
active sides: e
```

It's hex, but it looks like a bug, since there's no `0x` prefix. Also, most humans can't read hex, so I added a string representation.

New version:
```
[2025-08-06T11:56:00] DEBUG: active sides: LRT (0x0e)
```
2025-08-06 08:38:00 -04:00
47bb33e065 fix: update inclusion of climits and cstdint headers
For INT_MAX and SIZE_MAX.
2025-08-06 13:03:52 +01:00
40423397e3 refactor: Config remove redundant != Operator in server/Config 2025-08-06 11:44:38 +01:00
4955e8c2ba refactor: Fingerprint, KeyMap, KeySequence and Action use default == operator 2025-08-06 11:44:38 +01:00
24480ce946 refactor: AppUtilUnix remove name from unused IEventQueue pointer 2025-08-06 11:44:38 +01:00
76d5ac0a34 refactor: KeyTypes::KeyModifierNameMapEntry, remove commented code 2025-08-06 11:44:38 +01:00
d20887f34a refactor: KeyState::updateModifierState, use std::ranges::set_difference in place of std::set_difference 2025-08-06 11:44:38 +01:00