refactor: remove unneeded common/Common includes

src/lib/arch/ArchException.h

@@ -8,10 +8,7 @@
 
 #pragma once
 
-#include "common/Common.h"
-
 #include <stdexcept>
-#include <string>
 
 //! Generic thread exception
 /*!

src/lib/arch/ArchString.cpp

@@ -6,9 +6,9 @@
  */
 
 #include "arch/ArchString.h"
+#include "common/Common.h"
 
 #include <climits>
-#include <cstdlib>
 #include <cstring>
 #include <mutex>
 

src/lib/arch/ArchString.h

@@ -8,9 +8,8 @@
 
 #pragma once
 
-#include "common/Common.h"
-
 #include <stdarg.h>
+#include <stdint.h>
 
 //! Interface for architecture dependent string operations
 /*!

src/lib/arch/IArchDaemon.h

@@ -8,8 +8,6 @@
 
 #pragma once
 
-#include "common/Common.h"
-
 #include <functional>
 #include <string>
 

src/lib/arch/IArchLog.h

@@ -9,7 +9,6 @@
 #pragma once
 
 #include "base/LogLevel.h"
-#include "common/Common.h"
 
 //! Interface for architecture dependent logging
 /*!

src/lib/arch/IArchMultithread.h

@@ -8,7 +8,7 @@
 
 #pragma once
 
-#include "common/Common.h"
+#include <cstdint>
 
 /*!
 \class ArchCondImpl

src/lib/arch/IArchNetwork.h

@@ -8,9 +8,8 @@
 
 #pragma once
 
-#include "common/Common.h"
+#include <cstdint>
 #include <string>
-
 #include <vector>
 
 class ArchThreadImpl;

src/lib/arch/unix/ArchNetworkBSD.cpp

@@ -11,6 +11,7 @@
 #include "arch/ArchException.h"
 #include "arch/unix/ArchMultithreadPosix.h"
 #include "arch/unix/XArchUnix.h"
+#include "common/Common.h"
 
 #include <arpa/inet.h>
 #include <cstring>

src/lib/base/Event.cpp

@@ -7,6 +7,9 @@
 
 #include "base/Event.h"
 
+#include <assert.h>
+#include <cstdlib>
+
 //
 // Event
 //

src/lib/base/Event.h

@@ -8,7 +8,6 @@
 #pragma once
 
 #include "EventTypes.h"
-#include "common/Common.h"
 
 using deskflow::EventTypes;
 

src/lib/base/IEventJob.h

@@ -8,8 +8,6 @@
 
 #pragma once
 
-#include "common/Common.h"
-
 class Event;
 
 //! Event handler interface

src/lib/base/IEventQueue.h

@@ -10,7 +10,6 @@
 
 #include "base/Event.h"
 #include "base/EventTypes.h"
-#include "common/Common.h"
 
 #include <functional>
 #include <string>

src/lib/base/IEventQueueBuffer.h

@@ -8,7 +8,8 @@
 
 #pragma once
 
-#include "common/Common.h"
+#include <assert.h>
+#include <cstdint>
 
 class Event;
 class EventQueueTimer;

src/lib/base/IJob.h

@@ -8,8 +8,6 @@
 
 #pragma once
 
-#include "common/Common.h"
-
 //! Job interface
 /*!
 A job is an interface for executing some function.

src/lib/base/ILogOutputter.h

@@ -10,7 +10,6 @@
 
 #include "base/Log.h"
 #include "base/LogLevel.h"
-#include "common/Common.h"
 
 //! Outputter interface
 /*!

src/lib/base/Log.cpp

@@ -9,6 +9,7 @@
 #include "arch/Arch.h"
 #include "base/LogLevel.h"
 #include "base/LogOutputters.h"
+#include "common/Common.h"
 #include "common/Constants.h"
 
 #include <cstdarg>

src/lib/base/Log.h

@@ -9,7 +9,6 @@
 
 #include "arch/Arch.h"
 #include "arch/IArchMultithread.h"
-#include "common/Common.h"
 
 #include <mutex>
 

src/lib/base/LogOutputters.h

@@ -9,7 +9,6 @@
 #pragma once
 
 #include "base/ILogOutputter.h"
-#include "common/Common.h"
 #include "mt/Thread.h"
 
 //! Stop traversing log chain outputter

src/lib/base/Stopwatch.h

@@ -7,8 +7,6 @@
 
 #pragma once
 
-#include "common/Common.h"
-
 //! A timer class
 /*!
 This class measures time intervals.  All time interval measurement

src/lib/base/String.cpp

@@ -11,6 +11,7 @@
 #include <algorithm>
 #include <cstdarg>
 #include <cstdint>
+#include <cstring>
 #include <sstream>
 #include <vector>
 

src/lib/base/String.h

@@ -8,8 +8,6 @@
 
 #pragma once
 
-#include "common/Common.h"
-
 #include <string>
 
 //! std::string utilities

src/lib/base/Unicode.h

@@ -8,7 +8,7 @@
 #pragma once
 
 #include "arch/ArchString.h"
-#include "common/Common.h"
+
 #include <string>
 
 //! Unicode utility functions

src/lib/client/HelloBack.h

@@ -6,7 +6,6 @@
 
 #pragma once
 
-#include "common/Common.h"
 #include "deskflow/ProtocolTypes.h"
 #include "io/IStream.h"
 

src/lib/deskflow/AppUtil.cpp

@@ -8,6 +8,7 @@
 #include "deskflow/AppUtil.h"
 
 #include "algorithm"
+#include <assert.h>
 
 AppUtil *AppUtil::s_instance = nullptr;
 

src/lib/deskflow/Chunk.h

@@ -6,9 +6,10 @@
 
 #pragma once
 
-#include "common/Common.h"
 #include <base/Event.h>
 
+#include <cstring>
+
 class Chunk : public EventData
 {
 public:

src/lib/deskflow/ClipboardChunk.h

@@ -6,7 +6,6 @@
 
 #pragma once
 
-#include "common/Common.h"
 #include "deskflow/Chunk.h"
 #include "deskflow/ClipboardTypes.h"
 #include "deskflow/ProtocolTypes.h"

src/lib/deskflow/ClipboardTypes.h

@@ -7,7 +7,7 @@
 
 #pragma once
 
-#include "common/Common.h"
+#include <cstdint>
 
 //! Clipboard ID
 /*!

src/lib/deskflow/IApp.h

@@ -8,8 +8,6 @@
 
 #pragma once
 
-#include "common/Common.h"
-
 using StartupFunc = int (*)(int, char **);
 
 namespace deskflow {

src/lib/deskflow/IAppUtil.h

@@ -8,7 +8,6 @@
 
 #pragma once
 
-#include "common/Common.h"
 #include "deskflow/IApp.h"
 
 #include <string>

src/lib/deskflow/IClipboard.cpp

@@ -7,6 +7,7 @@
 
 #include "deskflow/IClipboard.h"
 
+#include <assert.h>
 #include <vector>
 
 //

src/lib/deskflow/IClipboard.h

@@ -9,8 +9,8 @@
 #pragma once
 
 #include "base/EventTypes.h"
-#include "common/Common.h"
 
+#include <cstdint>
 #include <string>
 
 //! Clipboard interface

src/lib/deskflow/IKeyState.cpp

@@ -6,6 +6,7 @@
  */
 
 #include "deskflow/IKeyState.h"
+#include "common/Common.h"
 
 #include <cstdint>
 #include <cstdlib>

src/lib/deskflow/IKeyState.h

@@ -11,7 +11,6 @@
 #include "base/Event.h"
 #include "base/EventTypes.h"
 #include "base/IEventQueue.h"
-#include "common/Common.h"
 #include "deskflow/KeyTypes.h"
 
 #include <set>

src/lib/deskflow/IPrimaryScreen.h

@@ -10,7 +10,6 @@
 
 #include "base/Event.h"
 #include "base/EventTypes.h"
-#include "common/Common.h"
 #include "deskflow/KeyTypes.h"
 #include "deskflow/MouseTypes.h"
 

src/lib/deskflow/IScreen.h

@@ -10,7 +10,6 @@
 
 #include "base/Event.h"
 #include "base/EventTypes.h"
-#include "common/Common.h"
 #include "deskflow/ClipboardTypes.h"
 
 class IClipboard;

src/lib/deskflow/IScreenSaver.h

@@ -9,7 +9,6 @@
 #pragma once
 
 #include "base/Event.h"
-#include "common/Common.h"
 
 //! Screen saver interface
 /*!

src/lib/deskflow/ISecondaryScreen.h

@@ -10,7 +10,6 @@
 
 #include "base/Event.h"
 #include "base/EventTypes.h"
-#include "common/Common.h"
 #include "deskflow/MouseTypes.h"
 
 //! Secondary screen interface

src/lib/deskflow/KeyTypes.h

@@ -7,8 +7,7 @@
 
 #pragma once
 
-#include "common/Common.h"
-
+#include <stdint.h>
 //! Key ID
 /*!
 Type to hold a key symbol identifier.  The encoding is UTF-32, using

src/lib/io/IStream.h

@@ -11,7 +11,6 @@
 #include "base/Event.h"
 #include "base/EventTypes.h"
 #include "base/IEventQueue.h"
-#include "common/Common.h"
 
 class IEventQueue;
 

src/lib/io/StreamBuffer.cpp

@@ -6,7 +6,8 @@
  */
 
 #include "io/StreamBuffer.h"
-#include "common/Common.h"
+
+#include <assert.h>
 
 //
 // StreamBuffer

src/lib/mt/CondVar.h

@@ -7,7 +7,6 @@
 
 #pragma once
 
-#include "common/Common.h"
 #include "mt/Mutex.h"
 
 class Stopwatch;

src/lib/mt/Lock.h

@@ -7,8 +7,6 @@
 
 #pragma once
 
-#include "common/Common.h"
-
 class Mutex;
 class CondVarBase;
 

src/lib/net/IDataSocket.cpp

@@ -8,6 +8,8 @@
 #include "net/IDataSocket.h"
 #include "base/EventQueue.h"
 
+#include <assert.h>
+
 //
 // IDataSocket
 //

src/lib/net/ISocket.h

@@ -10,7 +10,6 @@
 
 #include "base/Event.h"
 #include "base/EventTypes.h"
-#include "common/Common.h"
 
 class NetworkAddress;
 

src/lib/net/ISocketFactory.h

@@ -9,7 +9,6 @@
 #pragma once
 
 #include "arch/IArchNetwork.h"
-#include "common/Common.h"
 #include "net/SecurityLevel.h"
 
 class IDataSocket;

src/lib/net/ISocketMultiplexerJob.h

@@ -9,7 +9,6 @@
 #pragma once
 
 #include "arch/IArchNetwork.h"
-#include "common/Common.h"
 
 //! Socket multiplexer job
 /*!

src/lib/net/SocketException.h

@@ -9,7 +9,6 @@
 #pragma once
 
 #include "base/BaseException.h"
-#include "common/Common.h"
 #include "io/IOException.h"
 
 /**

src/lib/platform/IMSWindowsClipboardFacade.h

@@ -8,8 +8,6 @@
 
 #pragma once
 
-#include "common/Common.h"
-
 #define WIN32_LEAN_AND_MEAN
 #include <Windows.h>
 

src/lib/platform/IOSXKeyResource.h

@@ -9,6 +9,8 @@
 
 #include "deskflow/KeyState.h"
 
+#include <CoreServices/CoreServices.h>
+
 class IOSXKeyResource
 {
 public:

src/lib/platform/OSXCocoaApp.h

@@ -6,8 +6,6 @@
 
 #pragma once
 
-#include "common/Common.h"
-
 #import <CoreFoundation/CoreFoundation.h>
 
 #if defined(__cplusplus)

src/lib/platform/OSXPasteboardPeeker.h

@@ -6,8 +6,6 @@
 
 #pragma once
 
-#include "common/Common.h"
-
 #import <CoreFoundation/CoreFoundation.h>
 
 #if defined(__cplusplus)

src/lib/platform/OSXScreenSaverUtil.h

@@ -7,8 +7,6 @@
 
 #pragma once
 
-#include "common/Common.h"
-
 #if defined(__cplusplus)
 extern "C"
 {

src/lib/platform/XWindowsClipboard.cpp

@@ -10,7 +10,6 @@
 #include "arch/Arch.h"
 #include "base/Log.h"
 #include "base/Stopwatch.h"
-#include "common/Common.h"
 #include "platform/XWindowsClipboardBMPConverter.h"
 #include "platform/XWindowsClipboardHTMLConverter.h"
 #include "platform/XWindowsClipboardTextConverter.h"

src/lib/platform/XWindowsKeyState.h

@@ -7,6 +7,7 @@
 
 #pragma once
 
+#include "Config.h"
 #include "deskflow/KeyState.h"
 
 #include <map>

src/lib/server/Config.cpp

@@ -15,6 +15,7 @@
 #include "net/SocketException.h"
 #include "server/Server.h"
 
+#include <assert.h>
 #include <cstdlib>
 #include <istream>
 #include <ostream>

src/unittests/legacytests/legacytests/client/HelloBackTests.cpp

@@ -6,7 +6,6 @@
 
 #include "client/HelloBack.h"
 
-#include "common/Common.h"
 #include "unittests/legacytests/mock/io/MockStream.h"
 
 #include <array>