refactor: Hotkey use const for literals

This commit is contained in:
sithlord48
2025-01-05 16:28:47 -05:00
committed by Nick Bolton
parent 404458aab0
commit 20a5b8eb0b
2 changed files with 7 additions and 8 deletions

View File

@ -26,12 +26,8 @@ Hotkey::Hotkey() : m_KeySequence(), m_Actions()
QString Hotkey::text() const
{
QString text = keySequence().toString();
if (keySequence().isMouseButton())
return "mousebutton(" + text + ")";
return "keystroke(" + text + ")";
return keySequence().isMouseButton() ? kMousebutton.arg(keySequence().toString())
: kKeystroke.arg(keySequence().toString());
}
void Hotkey::loadSettings(QSettings &settings)
@ -39,7 +35,7 @@ void Hotkey::loadSettings(QSettings &settings)
keySequence().loadSettings(settings);
actions().clear();
int num = settings.beginReadArray("actions");
int num = settings.beginReadArray(kSectionActions);
for (int i = 0; i < num; i++) {
settings.setArrayIndex(i);
Action a;
@ -54,7 +50,7 @@ void Hotkey::saveSettings(QSettings &settings) const
{
keySequence().saveSettings(settings);
settings.beginWriteArray("actions");
settings.beginWriteArray(kSectionActions);
for (int i = 0; i < actions().size(); i++) {
settings.setArrayIndex(i);
actions()[i].saveSettings(settings);

View File

@ -70,6 +70,9 @@ protected:
private:
KeySequence m_KeySequence;
ActionList m_Actions;
inline static const QString kSectionActions = QStringLiteral("actions");
inline static const QString kMousebutton = QStringLiteral("mousebutton(%1)");
inline static const QString kKeystroke = QStringLiteral("keystroke(%1)");
};
using HotkeyList = QList<Hotkey>;