diff --git a/src/apps/deskflow-gui/Hotkey.cpp b/src/apps/deskflow-gui/Hotkey.cpp index e0eca537e..76fc7ecfd 100644 --- a/src/apps/deskflow-gui/Hotkey.cpp +++ b/src/apps/deskflow-gui/Hotkey.cpp @@ -26,12 +26,8 @@ Hotkey::Hotkey() : m_KeySequence(), m_Actions() QString Hotkey::text() const { - QString text = keySequence().toString(); - - if (keySequence().isMouseButton()) - return "mousebutton(" + text + ")"; - - return "keystroke(" + text + ")"; + return keySequence().isMouseButton() ? kMousebutton.arg(keySequence().toString()) + : kKeystroke.arg(keySequence().toString()); } void Hotkey::loadSettings(QSettings &settings) @@ -39,7 +35,7 @@ void Hotkey::loadSettings(QSettings &settings) keySequence().loadSettings(settings); actions().clear(); - int num = settings.beginReadArray("actions"); + int num = settings.beginReadArray(kSectionActions); for (int i = 0; i < num; i++) { settings.setArrayIndex(i); Action a; @@ -54,7 +50,7 @@ void Hotkey::saveSettings(QSettings &settings) const { keySequence().saveSettings(settings); - settings.beginWriteArray("actions"); + settings.beginWriteArray(kSectionActions); for (int i = 0; i < actions().size(); i++) { settings.setArrayIndex(i); actions()[i].saveSettings(settings); diff --git a/src/apps/deskflow-gui/Hotkey.h b/src/apps/deskflow-gui/Hotkey.h index 96f9c8548..98e3905d7 100644 --- a/src/apps/deskflow-gui/Hotkey.h +++ b/src/apps/deskflow-gui/Hotkey.h @@ -70,6 +70,9 @@ protected: private: KeySequence m_KeySequence; ActionList m_Actions; + inline static const QString kSectionActions = QStringLiteral("actions"); + inline static const QString kMousebutton = QStringLiteral("mousebutton(%1)"); + inline static const QString kKeystroke = QStringLiteral("keystroke(%1)"); }; using HotkeyList = QList;