refactor: String, pass stringToSizeType a const ref of the string we are to get the size of

src/lib/base/String.cpp

@@ -145,7 +145,7 @@ std::string sizeTypeToString(size_t n)
   return ss.str();
 }
 
-size_t stringToSizeType(std::string string)
+size_t stringToSizeType(const std::string &string)
 {
   std::istringstream iss(string);
   size_t value;

src/lib/base/String.h

@@ -52,7 +52,7 @@ std::string sizeTypeToString(size_t n);
 /*!
 Convert an a \c string to an size type
 */
-size_t stringToSizeType(std::string string);
+size_t stringToSizeType(const std::string &string);
 
 //! Case-insensitive comparisons
 /*!