fix: server: initialize the m_protocol member with a default value

It is likely random whether the server works or not without
a manually configured protocol option, which is neither documented
nor enforced to be set.
With a random uninitialized value in m_protocol, this can happen:
[2025-08-03T12:39:57] NOTE: accepted client connection
[2025-08-03T12:39:57] FATAL: a runtime error occurred: XInvalidProtocol

Reports of "it works with debug enabled" are likely due to having
parts of the memory space the server object is allocated into being
cleared, and thus having a 0 (Synergy) startup value.
This commit is contained in:
Christian Schmidt
2025-08-03 19:18:09 +02:00
committed by Nick Bolton
parent e69be64773
commit 1236fa4cab

View File

@ -358,7 +358,7 @@ private:
};
// used in hello message sent to the client
NetworkProtocol m_protocol;
NetworkProtocol m_protocol = NetworkProtocol::Barrier;
// the primary screen client
PrimaryClient *m_primaryClient;