9272e4019a
The embedded dashboard Chat tab dies on hosted images with a 502 / "[session ended]": the PTY child's `hermes --tui` spawn runs a runtime `npm install` that fails. Root cause: the root package-lock.json describes the WHOLE npm monorepo workspace set (root + web + ui-tui + apps/*), but the image only installs root/web/ui-tui — apps/* (the desktop app) is never `npm install`ed here, and its deps hoist into the shared root node_modules. So the actualized node_modules permanently disagrees with the canonical lock, `_tui_need_npm_install()` returns True on every launch, and the runtime `npm install` it triggers (a) can never converge against the partial monorepo and (b) races itself across concurrent /api/pty connections -> ENOTEMPTY -> the launcher `sys.exit(1)`s, the slow install blows past Fly's WS-upgrade window -> 502 -> the browser shows "[session ended]". Fix: set `ENV HERMES_TUI_DIR=/opt/hermes/ui-tui` so `_make_tui_argv` takes the prebuilt-bundle fast path (`node --expose-gc /opt/hermes/ui-tui/dist/entry.js`) and never reaches the install check — exactly the nix/packaged-release path the launcher was designed for. The bundle is already built at Layer 8 (`ui-tui && npm run build`); this just tells the launcher to use it. Verified on a freshly-built image: HERMES_TUI_DIR is set, the prebuilt dist/entry.js is present, `_make_tui_argv` resolves to the prebuilt node invocation (no npm), and `docker run ... --tui` no longer prints "npm install failed". New regression guard: tests/docker/test_tui_prebuilt_bundle.py. A separate launcher hardening (make _tui_need_npm_install tolerant of partial-monorepo installs) is tracked independently; this Docker-side fix resolves the hosted-chat symptom on its own. Area: docker (Dockerfile + tests/docker).
80 lines
3.5 KiB
Python
80 lines
3.5 KiB
Python
"""Harness: the image ships a prebuilt TUI bundle, not a runtime npm install.
|
|
|
|
Regression guard for the hosted-chat failure where the embedded dashboard
|
|
Chat tab died with a 502 / "[session ended]". Root cause: the image installs
|
|
only a subset of the npm monorepo workspaces (root/web/ui-tui, never apps/*),
|
|
so the actualized node_modules permanently disagrees with the canonical
|
|
package-lock.json. Without HERMES_TUI_DIR set, ``_make_tui_argv`` falls
|
|
through to ``_tui_need_npm_install`` (which returns True forever) and tries a
|
|
runtime ``npm install`` that can never converge and races itself across
|
|
concurrent /api/pty connections → ENOTEMPTY.
|
|
|
|
The fix is ``ENV HERMES_TUI_DIR=/opt/hermes/ui-tui`` in the Dockerfile, which
|
|
makes the launcher take the prebuilt-bundle fast path (``node --expose-gc
|
|
.../dist/entry.js``) and skip the install check entirely. These tests assert
|
|
that invariant holds in the built image.
|
|
"""
|
|
from __future__ import annotations
|
|
|
|
import json
|
|
import shlex
|
|
import subprocess
|
|
|
|
|
|
def _exec_py(image: str, py: str) -> str:
|
|
"""Run a Python snippet inside the image as the hermes user, return stdout."""
|
|
inner = (
|
|
"source /opt/hermes/.venv/bin/activate && "
|
|
"cd /opt/hermes && "
|
|
f"python3 -c {shlex.quote(py)}"
|
|
)
|
|
# Drop to the hermes user (UID 10000) so we exercise the same path the
|
|
# dashboard PTY child runs as — not root.
|
|
cmd = [
|
|
"docker", "run", "--rm", "--entrypoint", "su", image,
|
|
"hermes", "-s", "/bin/bash", "-c", inner,
|
|
]
|
|
r = subprocess.run(cmd, capture_output=True, text=True, timeout=120)
|
|
assert r.returncode == 0, f"in-container python failed:\n{r.stderr[-2000:]}"
|
|
return r.stdout.strip()
|
|
|
|
|
|
def test_hermes_tui_dir_env_is_set(built_image: str) -> None:
|
|
"""HERMES_TUI_DIR must point at the prebuilt bundle dir in the image."""
|
|
r = subprocess.run(
|
|
["docker", "run", "--rm", "--entrypoint", "sh", built_image,
|
|
"-c", 'printf "%s" "$HERMES_TUI_DIR"'],
|
|
capture_output=True, text=True, timeout=60,
|
|
)
|
|
assert r.returncode == 0, r.stderr[-2000:]
|
|
assert r.stdout.strip() == "/opt/hermes/ui-tui", (
|
|
f"HERMES_TUI_DIR={r.stdout.strip()!r} (expected /opt/hermes/ui-tui)"
|
|
)
|
|
|
|
|
|
def test_prebuilt_bundle_present_and_no_runtime_install(built_image: str) -> None:
|
|
"""The launcher must (a) find the prebuilt bundle and (b) NOT want an
|
|
npm install — i.e. it takes the same path as a nix/packaged release."""
|
|
py = (
|
|
"import json\n"
|
|
"from pathlib import Path\n"
|
|
"from hermes_cli.main import _tui_need_npm_install, _find_bundled_tui, _make_tui_argv\n"
|
|
"ui = Path('/opt/hermes/ui-tui')\n"
|
|
"argv, cwd = _make_tui_argv(ui, tui_dev=False)\n"
|
|
"out = {\n"
|
|
" 'dist_entry_exists': (ui / 'dist' / 'entry.js').is_file(),\n"
|
|
" 'need_npm_install': _tui_need_npm_install(ui),\n"
|
|
" 'argv': argv,\n"
|
|
" 'uses_prebuilt': ('dist/entry.js' in ' '.join(argv)) and ('npm' not in argv[0].lower()),\n"
|
|
"}\n"
|
|
"print(json.dumps(out))\n"
|
|
)
|
|
out = json.loads(_exec_py(built_image, py))
|
|
assert out["dist_entry_exists"], "prebuilt ui-tui/dist/entry.js missing from image"
|
|
# With HERMES_TUI_DIR set, _make_tui_argv returns the prebuilt path BEFORE
|
|
# ever reaching the install check — so the resolved argv is what matters.
|
|
assert out["uses_prebuilt"], f"launcher did not take prebuilt path: argv={out['argv']!r}"
|
|
assert "npm" not in out["argv"][0].lower(), (
|
|
f"launcher resolved to an npm invocation, not the prebuilt bundle: {out['argv']!r}"
|
|
)
|