827ce602db
Self-hosted Honcho setup had four sharp edges: - local/cloud URLs ending in /vN double-prefixed by the SDK (/v3/v3/... 404) - authenticated local servers had no setup prompt for a JWT/bearer token - profile-derived host keys could be dot-containing workspace IDs Honcho rejects - memory-provider config files with API keys written world-readable per umask This keeps existing behavior but makes those paths safer: - strip a trailing /vN version segment from any configured baseUrl before SDK init (the SDK's route builders always prepend their own version prefix); auth-skipping stays loopback-only - add an optional local JWT/bearer prompt in honcho setup, stored under hosts.<host>.apiKey - derive new profile host keys with underscores, still reading legacy hermes.<profile> blocks - write memory-provider config files atomically with 0600 via a shared utils.atomic_json_write(mode=) arg (honcho/hindsight/mem0/supermemory) - skip honcho.json parsing in gateway cache-busting unless Honcho is the active memory provider; memoize by honcho.json mtime when active - bust the gateway agent cache on memory.provider change - add a hermes memory setup <provider> one-liner so fresh installs can configure a named provider without the picker (the per-provider hermes <provider> subcommand only registers once that provider is active) Closes #20688, #29885, #26459, #30246, #33382, #32244. Co-authored-by: BROCCOLO1D
128 lines
4.7 KiB
Python
128 lines
4.7 KiB
Python
"""Tests for Honcho client configuration."""
|
|
|
|
import json
|
|
import os
|
|
import stat
|
|
from pathlib import Path
|
|
|
|
import pytest
|
|
|
|
from plugins.memory.honcho.client import HonchoClientConfig
|
|
from plugins.memory.honcho import HonchoMemoryProvider
|
|
|
|
|
|
class TestHonchoClientConfigAutoEnable:
|
|
"""Test auto-enable behavior when API key is present."""
|
|
|
|
def test_auto_enables_when_api_key_present_no_explicit_enabled(self, tmp_path):
|
|
"""When API key exists and enabled is not set, should auto-enable."""
|
|
config_path = tmp_path / "config.json"
|
|
config_path.write_text(json.dumps({
|
|
"apiKey": "test-api-key-12345",
|
|
# Note: no "enabled" field
|
|
}))
|
|
|
|
cfg = HonchoClientConfig.from_global_config(config_path=config_path)
|
|
|
|
assert cfg.api_key == "test-api-key-12345"
|
|
assert cfg.enabled is True # Auto-enabled because API key exists
|
|
|
|
def test_respects_explicit_enabled_false(self, tmp_path):
|
|
"""When enabled is explicitly False, should stay disabled even with API key."""
|
|
config_path = tmp_path / "config.json"
|
|
config_path.write_text(json.dumps({
|
|
"apiKey": "test-api-key-12345",
|
|
"enabled": False, # Explicitly disabled
|
|
}))
|
|
|
|
cfg = HonchoClientConfig.from_global_config(config_path=config_path)
|
|
|
|
assert cfg.api_key == "test-api-key-12345"
|
|
assert cfg.enabled is False # Respects explicit setting
|
|
|
|
def test_respects_explicit_enabled_true(self, tmp_path):
|
|
"""When enabled is explicitly True, should be enabled."""
|
|
config_path = tmp_path / "config.json"
|
|
config_path.write_text(json.dumps({
|
|
"apiKey": "test-api-key-12345",
|
|
"enabled": True,
|
|
}))
|
|
|
|
cfg = HonchoClientConfig.from_global_config(config_path=config_path)
|
|
|
|
assert cfg.api_key == "test-api-key-12345"
|
|
assert cfg.enabled is True
|
|
|
|
def test_disabled_when_no_api_key_and_no_explicit_enabled(self, tmp_path):
|
|
"""When no API key and enabled not set, should be disabled."""
|
|
config_path = tmp_path / "config.json"
|
|
config_path.write_text(json.dumps({
|
|
"workspace": "test",
|
|
# No apiKey, no enabled
|
|
}))
|
|
|
|
# Clear env var if set
|
|
env_key = os.environ.pop("HONCHO_API_KEY", None)
|
|
try:
|
|
cfg = HonchoClientConfig.from_global_config(config_path=config_path)
|
|
assert cfg.api_key is None
|
|
assert cfg.enabled is False # No API key = not enabled
|
|
finally:
|
|
if env_key:
|
|
os.environ["HONCHO_API_KEY"] = env_key
|
|
|
|
def test_auto_enables_with_env_var_api_key(self, tmp_path, monkeypatch):
|
|
"""When API key is in env var (not config), should auto-enable."""
|
|
config_path = tmp_path / "config.json"
|
|
config_path.write_text(json.dumps({
|
|
"workspace": "test",
|
|
# No apiKey in config
|
|
}))
|
|
|
|
monkeypatch.setenv("HONCHO_API_KEY", "env-api-key-67890")
|
|
|
|
cfg = HonchoClientConfig.from_global_config(config_path=config_path)
|
|
|
|
assert cfg.api_key == "env-api-key-67890"
|
|
assert cfg.enabled is True # Auto-enabled from env var API key
|
|
|
|
def test_from_env_always_enabled(self, monkeypatch):
|
|
"""from_env() should always set enabled=True."""
|
|
monkeypatch.setenv("HONCHO_API_KEY", "env-test-key")
|
|
|
|
cfg = HonchoClientConfig.from_env()
|
|
|
|
assert cfg.api_key == "env-test-key"
|
|
assert cfg.enabled is True
|
|
|
|
def test_falls_back_to_env_when_no_config_file(self, tmp_path, monkeypatch):
|
|
"""When config file doesn't exist, should fall back to from_env()."""
|
|
nonexistent = tmp_path / "nonexistent.json"
|
|
monkeypatch.setenv("HONCHO_API_KEY", "fallback-key")
|
|
|
|
cfg = HonchoClientConfig.from_global_config(config_path=nonexistent)
|
|
|
|
assert cfg.api_key == "fallback-key"
|
|
assert cfg.enabled is True # from_env() sets enabled=True
|
|
|
|
|
|
@pytest.mark.skipif(os.name == "nt", reason="POSIX mode bits not enforced on Windows")
|
|
def test_save_config_sets_owner_only_permissions(tmp_path, monkeypatch):
|
|
"""honcho.json is created atomically with 0o600, not chmod-after-write."""
|
|
import utils
|
|
calls = []
|
|
real_atomic = utils.atomic_json_write
|
|
|
|
def spy(path, data, **kwargs):
|
|
calls.append(kwargs.get("mode"))
|
|
return real_atomic(path, data, **kwargs)
|
|
|
|
monkeypatch.setattr(utils, "atomic_json_write", spy)
|
|
provider = HonchoMemoryProvider()
|
|
provider.save_config({"api_key": "hc-test-key"}, str(tmp_path))
|
|
assert calls == [0o600]
|
|
config_file = tmp_path / "honcho.json"
|
|
assert config_file.exists()
|
|
mode = stat.S_IMODE(config_file.stat().st_mode)
|
|
assert mode == 0o600, f"Expected 0o600 (owner-only), got {oct(mode)}"
|