leeseoki0
ce529d6072
fix(kanban): scratch tasks must not inherit board.default_workdir ( #28818 )
...
Board defaults represent persistent project checkouts. Scratch workspaces
are auto-deleted on completion and must stay under the per-board scratch
root that resolve_workspace() creates. Inheriting default_workdir for a
scratch task pointed the cleanup path at the user's source tree — the
data-loss vector documented in #28818 .
The containment guard in _cleanup_workspace (just added) is the safety
rail. This commit prevents the bad state from being created in the first
place: only persistent kinds (dir/worktree) inherit board defaults.
Tests updated to cover the new semantics: scratch with default_workdir
set keeps workspace_path=None; dir/worktree still inherits the board
default.
Salvaged from PR #31315 by @leeseoki0 — prevention layer on top of the
#28819 containment fix by @briandevans.
Co-authored-by: teknium1 <127238744+teknium1@users.noreply.github.com >
2026-05-24 15:48:58 -07:00
..
2026-05-22 14:17:40 -07:00
2026-05-16 02:58:57 -07:00
2026-05-23 21:03:51 -07:00
2026-05-08 14:27:40 -07:00
2026-05-18 20:10:52 -07:00
2026-05-24 04:25:32 -07:00
2026-05-18 10:14:38 -07:00
2026-05-11 11:13:25 -07:00
2026-05-15 14:45:43 -07:00
2026-05-19 22:34:05 -07:00
2026-05-18 21:38:05 -07:00
2026-04-14 16:11:37 -07:00
2026-05-11 11:13:25 -07:00
2026-05-11 11:13:25 -07:00
2026-04-13 16:32:04 -07:00
2026-05-13 22:54:21 -07:00
2026-05-11 11:13:25 -07:00
2026-05-15 02:31:30 -07:00
2026-05-17 02:29:41 -07:00
2026-03-30 17:07:21 -07:00
2026-05-23 17:47:26 -07:00
2026-05-13 09:34:15 -07:00
2026-05-24 15:36:37 -07:00
2026-05-11 11:13:25 -07:00
2026-05-18 17:39:50 +00:00
2026-05-11 11:13:25 -07:00
2026-05-21 23:40:58 -07:00
2026-05-24 15:43:48 -07:00
2026-03-26 01:34:27 -07:00
2026-05-18 16:34:24 +05:30
2026-05-11 11:13:25 -07:00
2026-05-20 09:18:23 -07:00
2026-05-21 14:18:02 -07:00
2026-05-24 02:19:57 -07:00
2026-05-23 05:24:57 -07:00
2026-05-23 05:24:57 -07:00
2026-05-23 02:30:41 -07:00
2026-05-24 04:24:44 -07:00
2026-05-16 23:05:27 -07:00
2026-05-11 11:13:25 -07:00
2026-05-13 22:31:11 -07:00
2026-05-24 15:48:58 -07:00
2026-05-18 20:26:02 -07:00
2026-05-18 20:47:01 -07:00
2026-05-18 20:15:20 -07:00
2026-05-18 21:10:12 -07:00
2026-05-23 23:10:36 -07:00
2026-04-11 17:23:36 -07:00
2026-05-24 15:15:16 -07:00
2026-05-15 01:43:54 -07:00
2026-05-14 07:59:38 -07:00
2026-05-20 09:18:23 -07:00
2026-05-08 14:27:40 -07:00
2026-05-06 09:08:33 -07:00
2026-05-19 10:57:35 -07:00
2026-05-16 02:24:48 -07:00
2026-05-06 10:05:29 -07:00
2026-05-23 18:18:41 -07:00
2026-05-07 07:18:21 -07:00
2026-04-29 21:56:51 -07:00
2026-05-22 19:50:32 -07:00
2026-05-23 17:49:47 -07:00
2026-05-23 02:39:09 -07:00
2026-05-21 14:18:02 -07:00
2026-05-21 14:18:02 -07:00
2026-05-21 14:18:02 -07:00
2026-05-18 14:31:37 -07:00
2026-05-09 12:48:14 -07:00
2026-05-11 11:13:25 -07:00
2026-05-08 14:27:40 -07:00
2026-05-21 07:48:53 -07:00
2026-05-24 02:19:57 -07:00
2026-05-12 01:02:25 -07:00
2026-05-24 15:15:16 -07:00
2026-05-16 23:00:58 -05:00
2026-05-17 02:29:41 -07:00
2026-05-24 15:16:03 -07:00
2026-04-29 04:03:03 -07:00
2026-05-23 17:47:26 -07:00
2026-05-18 20:05:23 -07:00
2026-05-08 17:01:12 -07:00
2026-05-23 16:13:01 -07:00
2026-05-11 11:13:25 -07:00
2026-05-19 14:25:10 -07:00
2026-05-19 22:34:05 -07:00
2026-05-23 02:39:09 -07:00
2026-05-18 20:05:47 -07:00
2026-04-29 07:22:33 -07:00
2026-05-06 15:49:59 -07:00
2026-05-24 15:00:44 -07:00
2026-05-24 04:55:18 -07:00
2026-05-20 09:18:23 -07:00