briandevans
280dd4513a
fix(computer-use): address Copilot review on max_elements cap
...
Four findings from Copilot's review on PR #22891 , all in the AX
elements-array cap added by 22fa1ed:
1. The truncation note ("response truncated to N of M elements") was
appended unconditionally — including in the som/vision multimodal
path, whose response carries a screenshot rather than an `elements`
array. The note described a payload field that wasn't present.
Moved the note into the AX-text branch where the array actually
appears.
2. `_format_elements(cap.elements)` ran on the full untrimmed list with
its own `max_lines=40` cap, so a caller passing `max_elements=10`
would see summary lines referencing `#11..#40` even though the JSON
`elements` array only held #1..#10. Format on `visible_elements`
instead so the summary indices always exist in the response.
3. `_coerce_max_elements` enforced a lower bound but no upper bound,
so `max_elements=10_000_000` silently disabled the safeguard and
reintroduced the original context-blow-up. Added a hard cap
(`_MAX_ALLOWED_MAX_ELEMENTS = 1000`) that clamps oversized values.
4. The schema string said "Default 100" but the property carried no
`default` field, and claimed `max_elements` had no effect on som/
vision while the image-missing fallback path can still return an
elements array. Added `"default": 100`, `"maximum": 1000`, and
clarified the fallback-path wording.
Each finding gets a regression test:
- test_capture_ax_clamps_oversized_max_elements_to_hard_cap
- test_capture_ax_summary_indices_match_returned_elements
- test_capture_multimodal_summary_omits_truncation_note
- test_schema_max_elements_documents_default_and_upper_bound
Verified with `pytest tests/tools/test_computer_use.py` (53 passed,
including the 5 new cases). Confirmed each new test fails on the
pre-fix code path before applying the production change.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com >
2026-05-21 19:07:32 -07:00
..
2026-02-26 03:20:08 +03:00
2026-05-21 16:40:04 +05:30
2026-04-29 20:05:32 -07:00
2026-03-23 07:43:12 -07:00
2026-05-08 14:55:40 -07:00
2026-05-21 16:40:04 +05:30
2026-05-16 01:24:25 -07:00
2026-05-04 04:45:03 -07:00
2026-05-12 15:14:49 -07:00
2026-05-12 15:14:49 -07:00
2026-04-24 03:46:46 -07:00
2026-04-17 16:05:04 -07:00
2026-04-24 03:46:46 -07:00
2026-05-13 22:07:02 -07:00
2026-04-08 13:44:58 -07:00
2026-04-16 04:19:34 -07:00
2026-05-09 13:35:39 -07:00
2026-04-20 00:32:09 -07:00
2026-03-28 17:25:04 -07:00
2026-05-10 07:37:55 -07:00
2026-04-10 13:05:44 -07:00
2026-05-17 02:29:41 -07:00
2026-04-26 09:57:58 -07:00
2026-05-06 03:41:21 -07:00
2026-05-08 14:27:40 -07:00
2026-04-01 12:03:56 -07:00
2026-05-07 05:38:05 -07:00
2026-04-30 20:33:33 -07:00
2026-05-21 16:40:04 +05:30
2026-04-11 02:58:48 -07:00
2026-05-09 17:53:13 -07:00
2026-05-14 07:59:12 -07:00
2026-02-27 03:29:26 -05:00
2026-05-13 22:54:21 -07:00
2026-05-17 02:29:41 -07:00
2026-05-08 14:27:40 -07:00
2026-05-08 14:27:40 -07:00
2026-05-08 14:55:40 -07:00
2026-05-21 17:38:19 -07:00
2026-05-21 17:38:19 -07:00
2026-05-21 19:07:32 -07:00
2026-03-27 04:03:00 -07:00
2026-04-10 03:44:43 -07:00
2026-05-08 14:55:40 -07:00
2026-05-08 07:30:14 -07:00
2026-02-26 13:55:54 +03:00
2026-05-19 00:10:43 -07:00
2026-05-12 16:31:46 -07:00
2026-03-02 04:34:21 -08:00
2026-05-07 06:41:42 -07:00
2026-04-24 04:58:32 -07:00
2026-03-26 14:50:26 -07:00
2026-05-17 11:40:05 -07:00
2026-05-21 16:40:04 +05:30
2026-04-29 16:16:43 +10:00
2026-04-14 21:20:37 -07:00
2026-05-07 06:17:49 -07:00
2026-05-17 11:51:46 -07:00
2026-04-21 06:14:25 -07:00
2026-04-17 19:04:11 -07:00
2026-05-05 04:54:17 -07:00
2026-05-19 17:27:24 -07:00
2026-04-17 19:26:40 -07:00
2026-04-27 00:17:26 -07:00
2026-04-23 15:11:52 -07:00
2026-04-21 16:41:26 -07:00
2026-05-09 11:12:03 -07:00
2026-04-10 03:01:46 -07:00
2026-04-10 21:14:32 -07:00
2026-04-20 00:58:16 -07:00
2026-04-08 17:23:15 -07:00
2026-05-08 16:59:24 -07:00
2026-04-13 05:15:05 -07:00
2026-03-14 11:27:02 -07:00
2026-04-21 02:03:46 -07:00
2026-05-11 06:56:30 -07:00
2026-05-04 05:08:51 -07:00
2026-05-17 02:29:41 -07:00
2026-05-21 16:40:04 +05:30
2026-05-15 01:33:13 -07:00
2026-04-23 03:01:18 -07:00
2026-04-21 13:35:31 -07:00
2026-04-28 22:16:08 -07:00
2026-04-14 02:18:38 -07:00
2026-05-18 21:01:14 -07:00
2026-05-21 16:40:04 +05:30
2026-05-14 08:03:40 -07:00
2026-05-17 23:28:45 -07:00
2026-04-19 11:27:50 -07:00
2026-04-29 07:22:33 -07:00
2026-05-04 15:31:47 -07:00
2026-05-15 16:25:31 -07:00
2026-04-29 23:18:55 -07:00
2026-04-23 05:15:37 -07:00
2026-04-09 16:24:53 -07:00
2026-05-17 04:04:15 -07:00
2026-04-16 12:36:49 -07:00
2026-05-17 02:29:41 -07:00
2026-04-16 12:36:49 -07:00
2026-05-17 02:29:41 -07:00
2026-04-21 05:19:03 -07:00
2026-04-29 20:05:32 -07:00
2026-05-07 06:33:57 -07:00
2026-05-07 07:14:16 -07:00
2026-05-16 13:06:56 -07:00
2026-04-19 16:31:07 -07:00
2026-04-19 16:31:07 -07:00
2026-04-16 21:57:10 -07:00
2026-04-16 21:57:10 -07:00
2026-05-07 05:35:33 -07:00
2026-05-17 02:29:37 -07:00
2026-05-15 14:00:01 -07:00
2026-04-16 21:57:10 -07:00
2026-05-07 07:08:04 -07:00
2026-05-17 13:33:26 -07:00
2026-05-15 14:00:01 -07:00
2026-04-16 21:57:10 -07:00
2026-04-04 10:18:57 -07:00
2026-05-07 06:32:45 -07:00
2026-05-17 11:41:26 -07:00
2026-05-07 07:39:50 -07:00
2026-04-14 10:18:05 -07:00
2026-05-07 07:03:21 -07:00
2026-04-13 16:32:04 -07:00
2026-05-08 09:27:26 -07:00
2026-05-08 09:27:26 -07:00
2026-04-23 15:14:11 -07:00
2026-04-12 06:18:05 +05:30
2026-04-29 07:22:33 -07:00
2026-04-10 03:01:46 -07:00
2026-04-12 00:36:22 -07:00
2026-04-05 12:46:07 -07:00
2026-04-22 14:45:50 -07:00
2026-05-20 01:46:40 -05:00
2026-05-19 01:28:32 -07:00
2026-04-13 16:32:04 -07:00
2026-05-13 17:32:22 -07:00
2026-04-23 15:11:52 -07:00
2026-05-18 10:37:35 -07:00
2026-03-17 02:02:57 -07:00
2026-04-15 17:37:43 -07:00
2026-05-18 22:19:50 -07:00
2026-05-21 16:40:04 +05:30
2026-05-17 23:28:45 -07:00
2026-04-26 11:55:02 -07:00
2026-04-20 13:24:15 -07:00
2026-05-17 02:29:41 -07:00
2026-04-10 03:44:43 -07:00
2026-04-01 04:19:19 -07:00
2026-05-17 02:29:41 -07:00
2026-05-08 14:55:40 -07:00
2026-04-01 04:19:19 -07:00
2026-05-07 06:13:37 -07:00
2026-03-04 05:30:43 -08:00
2026-03-02 02:00:09 -08:00
2026-04-23 06:20:47 -07:00
2026-05-19 14:17:38 -07:00
2026-05-09 17:52:12 -07:00
2026-05-20 15:04:01 -07:00
2026-04-23 05:09:08 -07:00
2026-05-21 14:18:02 -07:00
2026-04-29 21:56:47 -07:00
2026-04-24 07:06:11 -07:00
2026-04-30 04:32:28 -07:00
2026-04-20 03:07:32 -07:00
2026-03-04 17:23:23 +03:00
2026-04-16 19:39:21 -07:00
2026-04-19 16:53:11 -07:00
2026-05-09 17:53:35 -07:00
2026-04-04 16:57:24 -07:00
2026-04-19 16:47:20 -07:00
2026-04-08 21:37:51 -07:00
2026-04-20 23:20:33 -07:00
2026-04-29 07:22:33 -07:00
2026-05-09 14:46:34 -07:00
2026-03-29 21:51:44 -07:00
2026-04-09 16:24:53 -07:00
2026-05-21 16:40:04 +05:30
2026-04-30 20:38:09 -07:00
2026-04-08 17:23:15 -07:00
2026-05-18 10:20:07 -07:00
2026-04-11 16:22:50 -07:00
2026-04-26 19:02:55 -07:00
2026-04-23 21:51:19 -07:00
2026-05-09 18:44:58 -07:00
2026-05-17 11:55:25 -07:00
2026-05-13 10:31:22 -07:00
2026-05-13 17:32:22 -07:00
2026-04-30 02:53:20 -07:00
2026-05-15 12:11:32 -07:00
2026-04-16 14:23:16 -07:00
2026-05-13 17:32:22 -07:00
2026-04-21 17:49:39 -07:00
2026-05-11 23:02:15 -07:00
2026-05-18 22:29:45 -07:00
2026-04-30 02:53:20 -07:00
2026-05-13 22:04:28 -07:00
2026-05-20 09:22:28 -07:00
2026-05-18 10:51:15 -07:00
2026-05-08 14:55:40 -07:00
2026-05-04 00:04:36 +05:30
2026-05-13 16:39:41 -07:00
2026-05-13 16:39:41 -07:00
2026-05-21 16:40:04 +05:30
2026-05-12 13:59:22 -04:00
2026-04-20 00:32:09 -07:00
2026-05-21 14:17:39 -07:00
2026-05-21 14:17:39 -07:00
2026-04-25 06:41:58 -07:00
2026-05-21 16:40:04 +05:30
2026-05-21 16:40:04 +05:30
2026-05-21 16:40:04 +05:30
2026-05-19 19:27:34 -07:00
2026-05-21 16:40:04 +05:30
2026-05-13 22:31:28 -07:00
2026-05-21 16:40:04 +05:30
2026-05-21 16:40:04 +05:30
2026-03-01 01:54:27 +03:00
2026-05-12 01:02:25 -07:00
2026-05-21 16:40:04 +05:30
2026-05-21 02:38:45 +05:30
2026-04-30 20:37:37 -07:00
2026-05-19 17:27:24 -07:00