fix(mcp): banner shows 'disabled' not 'failed' for enabled:false servers (#38204)

get_mcp_status() treated every non-connected server as a failure, so a
server configured with enabled: false rendered as red '— failed' in the
startup banner even though it was intentionally off. Add a 'disabled'
field derived from the enabled flag and render disabled servers dim as
'— disabled' instead.
This commit is contained in:
Teknium
2026-06-03 05:41:13 -07:00
committed by GitHub
parent ef65298103
commit 1d90b23982
3 changed files with 45 additions and 0 deletions

View File

@ -3666,6 +3666,7 @@ def get_mcp_status() -> List[dict]:
for name, cfg in configured.items():
transport = cfg.get("transport", "http") if "url" in cfg else "stdio"
enabled = _parse_boolish(cfg.get("enabled", True), default=True)
server = active_servers.get(name)
if server and server.session is not None:
entry = {
@ -3673,16 +3674,21 @@ def get_mcp_status() -> List[dict]:
"transport": transport,
"tools": len(server._registered_tool_names) if hasattr(server, "_registered_tool_names") else len(server._tools),
"connected": True,
"disabled": False,
}
if server._sampling:
entry["sampling"] = dict(server._sampling.metrics)
result.append(entry)
else:
# A server with enabled: false is intentionally not connected — it is
# disabled, not failed. Surface that distinction so consumers (banner,
# TUI) can render "disabled" rather than an alarming "failed".
result.append({
"name": name,
"transport": transport,
"tools": 0,
"connected": False,
"disabled": not enabled,
})
return result