From fe67b92cdcfc815ff8217866d8979417d8bb2d1d Mon Sep 17 00:00:00 2001
From: Nicolas Fella <nicolas.fella@gmx.de>
Date: Sat, 12 Oct 2024 17:55:48 +0200
Subject: [PATCH] build: Drop warnings_as_errors

This should not be used

It results in build failures when using different environments/toolchains that produce new warnings

This can especially happen on compiler or dependency updates
---
 .github/workflows/ci.yml |  8 ++++----
 cmake/Build.cmake        | 11 -----------
 2 files changed, 4 insertions(+), 15 deletions(-)

diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
index e498cdff1..e8411cb4b 100644
--- a/.github/workflows/ci.yml
+++ b/.github/workflows/ci.yml
@@ -165,7 +165,7 @@ jobs:
       - name: Configure
         env:
           VCPKG_ROOT: ${{github.workspace}}/vcpkg
-        run: cmake -B build --preset=windows-release
+        run: cmake -B build --preset=windows-release -DCMAKE_COMPILE_WARNING_AS_ERROR=ON
 
       - name: Build
         run: cmake --build build -j8
@@ -234,7 +234,7 @@ jobs:
         run: ./scripts/install_deps.py
 
       - name: Configure
-        run: cmake -B build --preset=macos-release
+        run: cmake -B build --preset=macos-release -DCMAKE_COMPILE_WARNING_AS_ERROR=ON
 
       - name: Build
         run: cmake --build build -j8
@@ -309,7 +309,7 @@ jobs:
           DEBIAN_FRONTEND: noninteractive
 
       - name: Configure
-        run: cmake -B build --preset=linux-release ${{ matrix.distro.extra-cmake-args }} -DCMAKE_INSTALL_PREFIX=/usr
+        run: cmake -B build --preset=linux-release ${{ matrix.distro.extra-cmake-args }} -DCMAKE_INSTALL_PREFIX=/usr -DCMAKE_COMPILE_WARNING_AS_ERROR=ON
 
       - name: Build
         run: cmake --build build -j8
@@ -343,7 +343,7 @@ jobs:
       DESKFLOW_BUILD_CMD: |
         ./scripts/install_deps.sh;
         cmake -B build;
-        cmake --build build -j16;
+        cmake --build build -j16; -DCMAKE_COMPILE_WARNING_AS_ERROR=ON
         export QT_QPA_PLATFORM=offscreen;
         ./build/bin/unittests
         ./build/bin/integtests
diff --git a/cmake/Build.cmake b/cmake/Build.cmake
index 0b1340cbc..7e1c0bdb6 100644
--- a/cmake/Build.cmake
+++ b/cmake/Build.cmake
@@ -26,22 +26,11 @@ macro(configure_build)
     set(CMAKE_OSX_DEPLOYMENT_TARGET "12.0")
   endif()
 
-  warnings_as_errors()
   set_build_date()
   configure_file_shared()
 
 endmacro()
 
-macro(warnings_as_errors)
-  if(WIN32)
-    message(STATUS "Enabling warnings as errors (MSVC)")
-    add_compile_options(/WX)
-  elseif(UNIX)
-    message(STATUS "Enabling warnings as errors (GNU/Clang)")
-    add_compile_options(-Werror)
-  endif()
-endmacro()
-
 macro(set_build_date)
   # Since CMake 3.8.0, `string(TIMESTAMP ...)` respects `SOURCE_DATE_EPOCH` env var if set,
   # which allows package maintainers to create reproducible builds.