From f9c8d08ff79defdabd4d8e055433ceb8b217cc86 Mon Sep 17 00:00:00 2001
From: sithlord48 <sithlord48@gmail.com>
Date: Mon, 24 Mar 2025 21:09:54 -0400
Subject: [PATCH] chore: remove unused string::splitString

---
 src/lib/base/String.cpp                 | 21 -------
 src/lib/base/String.h                   |  6 --
 src/test/unittests/base/StringTests.cpp | 75 -------------------------
 3 files changed, 102 deletions(-)

diff --git a/src/lib/base/String.cpp b/src/lib/base/String.cpp
index 93908e0f1..c4f0bc6b6 100644
--- a/src/lib/base/String.cpp
+++ b/src/lib/base/String.cpp
@@ -248,27 +248,6 @@ size_t stringToSizeType(std::string string)
   return value;
 }
 
-std::vector<std::string> splitString(std::string string, const char c)
-{
-  std::vector<std::string> results;
-
-  size_t head = 0;
-  size_t separator = string.find(c);
-  while (separator != std::string::npos) {
-    if (head != separator) {
-      results.push_back(string.substr(head, separator - head));
-    }
-    head = separator + 1;
-    separator = string.find(c, head);
-  }
-
-  if (head < string.size()) {
-    results.push_back(string.substr(head, string.size() - head));
-  }
-
-  return results;
-}
-
 //
 // CaselessCmp
 //
diff --git a/src/lib/base/String.h b/src/lib/base/String.h
index 071d6980f..fb13ff57d 100644
--- a/src/lib/base/String.h
+++ b/src/lib/base/String.h
@@ -94,12 +94,6 @@ Convert an a \c string to an size type
 */
 size_t stringToSizeType(std::string string);
 
-//! Split a string into substrings
-/*!
-Split a \c string that separated by a \c c into substrings
-*/
-std::vector<std::string> splitString(std::string string, const char c);
-
 //! Case-insensitive comparisons
 /*!
 This class provides case-insensitve comparison functions.
diff --git a/src/test/unittests/base/StringTests.cpp b/src/test/unittests/base/StringTests.cpp
index 0d55de323..a9c87d0b0 100644
--- a/src/test/unittests/base/StringTests.cpp
+++ b/src/test/unittests/base/StringTests.cpp
@@ -106,78 +106,3 @@ TEST(StringTests, stringToUint_inputString_outputInt)
 
   EXPECT_EQ(123, value);
 }
-
-TEST(StringTests, splitString_twoSeparator_returnThreeParts)
-{
-  std::string string = "stub1:stub2:stub3";
-
-  std::vector<std::string> results = string::splitString(string, ':');
-
-  EXPECT_EQ(3, results.size());
-  EXPECT_EQ("stub1", results[0]);
-  EXPECT_EQ("stub2", results[1]);
-  EXPECT_EQ("stub3", results[2]);
-}
-
-TEST(StringTests, splitString_oneSeparator_returnTwoParts)
-{
-  std::string string = "stub1:stub2";
-
-  std::vector<std::string> results = string::splitString(string, ':');
-
-  EXPECT_EQ(2, results.size());
-  EXPECT_EQ("stub1", results[0]);
-  EXPECT_EQ("stub2", results[1]);
-}
-
-TEST(StringTests, splitString_noSeparator_returnOriginalString)
-{
-  std::string string = "stub1";
-
-  std::vector<std::string> results = string::splitString(string, ':');
-
-  EXPECT_EQ(1, results.size());
-  EXPECT_EQ("stub1", results[0]);
-}
-
-TEST(StringTests, splitString_emptyString_returnEmptyVector)
-{
-  std::string string;
-
-  std::vector<std::string> results = string::splitString(string, ':');
-
-  EXPECT_EQ(0, results.size());
-}
-
-TEST(StringTests, splitString_tailSeparator_returnTwoParts)
-{
-  std::string string = "stub1:stub2:";
-
-  std::vector<std::string> results = string::splitString(string, ':');
-
-  EXPECT_EQ(2, results.size());
-  EXPECT_EQ("stub1", results[0]);
-  EXPECT_EQ("stub2", results[1]);
-}
-
-TEST(StringTests, splitString_headSeparator_returnTwoParts)
-{
-  std::string string = ":stub1:stub2";
-
-  std::vector<std::string> results = string::splitString(string, ':');
-
-  EXPECT_EQ(2, results.size());
-  EXPECT_EQ("stub1", results[0]);
-  EXPECT_EQ("stub2", results[1]);
-}
-
-TEST(StringTests, splitString_headAndTailSeparators_returnTwoParts)
-{
-  std::string string = ":stub1:stub2:";
-
-  std::vector<std::string> results = string::splitString(string, ':');
-
-  EXPECT_EQ(2, results.size());
-  EXPECT_EQ("stub1", results[0]);
-  EXPECT_EQ("stub2", results[1]);
-}