From f69bd5601c3e3b73c9ba3ce359e819334da01d07 Mon Sep 17 00:00:00 2001 From: sithlord48 Date: Mon, 23 Feb 2026 21:07:10 -0500 Subject: [PATCH] refactor: make NetworkMonitor::validAddresses static --- src/lib/gui/MainWindow.cpp | 4 ++-- src/lib/gui/core/NetworkMonitor.cpp | 2 +- src/lib/gui/core/NetworkMonitor.h | 2 +- src/lib/gui/dialogs/SettingsDialog.cpp | 4 ++-- 4 files changed, 6 insertions(+), 6 deletions(-) diff --git a/src/lib/gui/MainWindow.cpp b/src/lib/gui/MainWindow.cpp index edb5aac26..46b6d9cf2 100644 --- a/src/lib/gui/MainWindow.cpp +++ b/src/lib/gui/MainWindow.cpp @@ -395,7 +395,7 @@ void MainWindow::startCore() { // Save current IP state when server starts if (m_coreProcess.mode() == CoreMode::Server && Settings::value(Settings::Core::Interface).toString().isEmpty()) { - m_serverStartIPs = m_networkMonitor->validAddresses(); + m_serverStartIPs = NetworkMonitor::validAddresses(); m_serverStartSuggestedIP = m_serverStartIPs.isEmpty() ? "" : m_serverStartIPs.first(); } @@ -585,7 +585,7 @@ void MainWindow::updateSecurityIcon(bool visible) void MainWindow::updateNetworkInfo() { - updateIpLabel(m_networkMonitor->validAddresses()); + updateIpLabel(NetworkMonitor::validAddresses()); } void MainWindow::serverConnectionConfigureClient(const QString &clientName) diff --git a/src/lib/gui/core/NetworkMonitor.cpp b/src/lib/gui/core/NetworkMonitor.cpp index 26713c7b8..b58ca45fb 100644 --- a/src/lib/gui/core/NetworkMonitor.cpp +++ b/src/lib/gui/core/NetworkMonitor.cpp @@ -52,7 +52,7 @@ void NetworkMonitor::stopMonitoring() m_isMonitoring = false; } -QStringList NetworkMonitor::validAddresses() const +QStringList NetworkMonitor::validAddresses() { QList physicalIP4; QList physicalIP6; diff --git a/src/lib/gui/core/NetworkMonitor.h b/src/lib/gui/core/NetworkMonitor.h index ce7ac6af1..f687fb713 100644 --- a/src/lib/gui/core/NetworkMonitor.h +++ b/src/lib/gui/core/NetworkMonitor.h @@ -50,7 +50,7 @@ public: * @brief Get list of all available IP addresses (excluding local and link-local addresses) * @return IP address list */ - QStringList validAddresses() const; + static QStringList validAddresses(); /** * @brief Check if a network interface is virtual diff --git a/src/lib/gui/dialogs/SettingsDialog.cpp b/src/lib/gui/dialogs/SettingsDialog.cpp index 6c13b3158..ffb846ae9 100644 --- a/src/lib/gui/dialogs/SettingsDialog.cpp +++ b/src/lib/gui/dialogs/SettingsDialog.cpp @@ -55,8 +55,8 @@ SettingsDialog::SettingsDialog(QWidget *parent, const IServerConfig &serverConfi ui->tabWidget->setCurrentIndex(0); // Populate the list of IP addresses - NetworkMonitor networkMonitor(this); - for (const auto &address : networkMonitor.validAddresses()) { + const auto validAddresses = NetworkMonitor::validAddresses(); + for (const auto &address : validAddresses) { QString ipString = address; if (ui->comboInterface->findText(ipString) == -1) { ui->comboInterface->addItem(ipString, ipString);