From ec9f7efcff8e59656a5118d73739b22c1988e6e5 Mon Sep 17 00:00:00 2001 From: sithlord48 Date: Thu, 13 Nov 2025 10:36:45 -0500 Subject: [PATCH] refactor: Logger is now a proper singleton --- src/lib/gui/Logger.h | 4 ++++ src/unittests/gui/LoggerTests.cpp | 11 ++++------- 2 files changed, 8 insertions(+), 7 deletions(-) diff --git a/src/lib/gui/Logger.h b/src/lib/gui/Logger.h index 6a560edc4..9bd1457bf 100644 --- a/src/lib/gui/Logger.h +++ b/src/lib/gui/Logger.h @@ -25,6 +25,10 @@ public: Q_SIGNALS: void newLine(const QString &line); + +private: + explicit Logger() = default; + ~Logger() = default; }; } // namespace deskflow::gui diff --git a/src/unittests/gui/LoggerTests.cpp b/src/unittests/gui/LoggerTests.cpp index db7ce3950..8b1187015 100644 --- a/src/unittests/gui/LoggerTests.cpp +++ b/src/unittests/gui/LoggerTests.cpp @@ -30,13 +30,11 @@ void LoggerTests::initTestCase() void LoggerTests::newLine() { - Logger logger; - - QSignalSpy spy(&logger, &Logger::newLine); + QSignalSpy spy(Logger::instance(), &Logger::newLine); QVERIFY(spy.isValid()); Settings::setValue(Settings::Log::GuiDebug, true); - logger.handleMessage(QtDebugMsg, "stub", "test"); + Logger::instance()->handleMessage(QtDebugMsg, "stub", "test"); QCOMPARE(spy.count(), 1); QVERIFY(qvariant_cast(spy.takeFirst().at(0)).contains("test")); @@ -45,14 +43,13 @@ void LoggerTests::newLine() void LoggerTests::noNewLine() { - Logger logger; bool newLineEmitted = false; - QSignalSpy spy(&logger, &Logger::newLine); + QSignalSpy spy(Logger::instance(), &Logger::newLine); QVERIFY(spy.isValid()); Settings::setValue(Settings::Log::GuiDebug, false); - logger.handleMessage(QtDebugMsg, "stub", "test"); + Logger::instance()->handleMessage(QtDebugMsg, "stub", "test"); QCOMPARE(spy.count(), 0); QVERIFY(!newLineEmitted); }