From e20ef3ae5567ea6da1f71fd0abb45c86266d6edb Mon Sep 17 00:00:00 2001 From: sithlord48 Date: Wed, 30 Apr 2025 22:04:58 -0400 Subject: [PATCH] chore: LogOutputters, use default for deconstructor / constructors --- src/lib/base/LogOutputters.cpp | 32 -------------------------------- src/lib/base/LogOutputters.h | 16 ++++++++-------- 2 files changed, 8 insertions(+), 40 deletions(-) diff --git a/src/lib/base/LogOutputters.cpp b/src/lib/base/LogOutputters.cpp index eb59883fa..6a5616610 100644 --- a/src/lib/base/LogOutputters.cpp +++ b/src/lib/base/LogOutputters.cpp @@ -22,16 +22,6 @@ enum EFileLogOutputter // StopLogOutputter // -StopLogOutputter::StopLogOutputter() -{ - // do nothing -} - -StopLogOutputter::~StopLogOutputter() -{ - // do nothing -} - void StopLogOutputter::open(const char *) { // do nothing @@ -56,14 +46,6 @@ bool StopLogOutputter::write(ELevel, const char *) // ConsoleLogOutputter // -ConsoleLogOutputter::ConsoleLogOutputter() -{ -} - -ConsoleLogOutputter::~ConsoleLogOutputter() -{ -} - void ConsoleLogOutputter::open(const char *title) { ARCH->openConsole(title); @@ -93,16 +75,6 @@ void ConsoleLogOutputter::flush() // SystemLogOutputter // -SystemLogOutputter::SystemLogOutputter() -{ - // do nothing -} - -SystemLogOutputter::~SystemLogOutputter() -{ - // do nothing -} - void SystemLogOutputter::open(const char *title) { ARCH->openLog(title); @@ -159,10 +131,6 @@ FileLogOutputter::FileLogOutputter(const char *logFile) setLogFilename(logFile); } -FileLogOutputter::~FileLogOutputter() -{ -} - void FileLogOutputter::setLogFilename(const char *logFile) { assert(logFile != nullptr); diff --git a/src/lib/base/LogOutputters.h b/src/lib/base/LogOutputters.h index c85feddcc..3df6c4800 100644 --- a/src/lib/base/LogOutputters.h +++ b/src/lib/base/LogOutputters.h @@ -21,8 +21,8 @@ this to prevent already inserted outputters from writing. class StopLogOutputter : public ILogOutputter { public: - StopLogOutputter(); - ~StopLogOutputter() override; + StopLogOutputter() = default; + ~StopLogOutputter() override = default; // ILogOutputter overrides void open(const char *title) override; @@ -39,8 +39,8 @@ message is ignored. class ConsoleLogOutputter : public ILogOutputter { public: - ConsoleLogOutputter(); - ~ConsoleLogOutputter() override; + ConsoleLogOutputter() = default; + ~ConsoleLogOutputter() override = default; // ILogOutputter overrides void open(const char *title) override; @@ -59,8 +59,8 @@ message is ignored. class FileLogOutputter : public ILogOutputter { public: - FileLogOutputter(const char *logFile); - ~FileLogOutputter() override; + explicit FileLogOutputter(const char *logFile); + ~FileLogOutputter() override = default; // ILogOutputter overrides void open(const char *title) override; @@ -81,8 +81,8 @@ This outputter writes output to the system log. class SystemLogOutputter : public ILogOutputter { public: - SystemLogOutputter(); - ~SystemLogOutputter() override; + SystemLogOutputter() = default; + ~SystemLogOutputter() override = default; // ILogOutputter overrides void open(const char *title) override;