From bb88bd8695d4155539102fe97cf7324e680547f2 Mon Sep 17 00:00:00 2001 From: re2zero Date: Fri, 16 Jan 2026 10:37:34 +0800 Subject: [PATCH] refactor: remove unneeded QIcon when setting from theme explict cast when setting update url --- src/lib/gui/MainWindow.cpp | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/lib/gui/MainWindow.cpp b/src/lib/gui/MainWindow.cpp index 9189a4583..786ad3bb5 100644 --- a/src/lib/gui/MainWindow.cpp +++ b/src/lib/gui/MainWindow.cpp @@ -104,10 +104,10 @@ MainWindow::MainWindow() m_actionTrayQuit->setShortcut(QKeySequence::Quit); } - m_actionQuit->setIcon(QIcon(QIcon::fromTheme("application-exit"))); + m_actionQuit->setIcon(QIcon::fromTheme("application-exit")); m_actionQuit->setMenuRole(QAction::QuitRole); - m_actionTrayQuit->setIcon(QIcon(QIcon::fromTheme("application-exit"))); + m_actionTrayQuit->setIcon(QIcon::fromTheme("application-exit")); m_actionTrayQuit->setMenuRole(QAction::NoRole); m_actionClearSettings->setIcon(QIcon::fromTheme(QStringLiteral("edit-clear-all"))); @@ -126,7 +126,7 @@ MainWindow::MainWindow() m_actionStopCore->setIcon(QIcon::fromTheme(QIcon::ThemeIcon::ProcessStop)); m_actionStopCore->setMenuRole(QAction::NoRole); - m_actionReportBug->setIcon(QIcon(QIcon::fromTheme(QStringLiteral("tools-report-bug")))); + m_actionReportBug->setIcon(QIcon::fromTheme(QStringLiteral("tools-report-bug"))); m_actionReportBug->setMenuRole(QAction::NoRole); // Setup the Instance Checking @@ -486,7 +486,7 @@ void MainWindow::openHelpUrl() const void MainWindow::openGetNewVersionUrl() const { - QDesktopServices::openUrl(kUrlDownload); + QDesktopServices::openUrl(QUrl(kUrlDownload)); } void MainWindow::openSettings()