From ac7bd1cecad7e87f6143a7f6ba6eb9ac79a40434 Mon Sep 17 00:00:00 2001
From: sithlord48 <sithlord48@gmail.com>
Date: Fri, 10 Oct 2025 20:29:02 -0400
Subject: [PATCH] refactor: CoreProcess make wrapIpv6, Simplify wrapIpV6 method

---
 src/lib/gui/core/CoreProcess.cpp | 18 +++++++++++-------
 src/lib/gui/core/CoreProcess.h   |  1 +
 2 files changed, 12 insertions(+), 7 deletions(-)

diff --git a/src/lib/gui/core/CoreProcess.cpp b/src/lib/gui/core/CoreProcess.cpp
index b8bb60b57..9fa8b3fe7 100644
--- a/src/lib/gui/core/CoreProcess.cpp
+++ b/src/lib/gui/core/CoreProcess.cpp
@@ -66,23 +66,27 @@ QString CoreProcess::makeQuotedArgs(const QString &app, const QStringList &args)
 /**
  * @brief If IPv6, ensures the IP is surround in square brackets.
  */
-QString wrapIpv6(const QString &address)
+QString CoreProcess::wrapIpv6(const QString &address)
 {
-  if (!address.contains(':') || address.isEmpty()) {
+  static const auto colon = QStringLiteral(":");
+  static const auto openBracket = QStringLiteral("[");
+  static const auto closeBracket = QStringLiteral("]");
+
+  if (!address.contains(colon) || address.isEmpty()) {
     return address;
   }
 
   QString wrapped = address;
 
-  if (address[0] != '[') {
-    wrapped.insert(0, '[');
+  if (!address.startsWith(openBracket)) {
+    wrapped.prepend(openBracket);
   }
 
-  if (address[address.size() - 1] != ']') {
-    wrapped.push_back(']');
+  if (!address.endsWith(closeBracket)) {
+    wrapped.append(closeBracket);
   }
 
-  return address;
+  return wrapped;
 }
 
 //
diff --git a/src/lib/gui/core/CoreProcess.h b/src/lib/gui/core/CoreProcess.h
index 34e73f221..d456ceeba 100644
--- a/src/lib/gui/core/CoreProcess.h
+++ b/src/lib/gui/core/CoreProcess.h
@@ -125,6 +125,7 @@ private:
   static QString makeQuotedArgs(const QString &app, const QStringList &args);
   static QString processModeToString(const Settings::ProcessMode mode);
   static QString processStateToString(const CoreProcess::ProcessState state);
+  static QString wrapIpv6(const QString &address);
 
 #ifdef Q_OS_MAC
   void checkOSXNotification(const QString &line);