From a3875bf71c70d13362147b14b68cbfb152fda532 Mon Sep 17 00:00:00 2001 From: sithlord48 Date: Sat, 22 Mar 2025 09:46:47 -0400 Subject: [PATCH] fix: small leak on closing of mainwindow by not parenting the menus, found via valgrind --- src/apps/deskflow-gui/MainWindow.cpp | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/apps/deskflow-gui/MainWindow.cpp b/src/apps/deskflow-gui/MainWindow.cpp index 9bad6e6ac..5b0d730eb 100644 --- a/src/apps/deskflow-gui/MainWindow.cpp +++ b/src/apps/deskflow-gui/MainWindow.cpp @@ -640,16 +640,16 @@ void MainWindow::setStatus(const QString &status) void MainWindow::createMenuBar() { - auto menuFile = new QMenu(tr("File")); + auto menuFile = new QMenu(tr("File"), this); menuFile->addAction(m_actionStartCore); menuFile->addAction(m_actionStopCore); menuFile->addSeparator(); menuFile->addAction(m_actionQuit); - auto menuEdit = new QMenu(tr("Edit")); + auto menuEdit = new QMenu(tr("Edit"), this); menuEdit->addAction(m_actionSettings); - auto menuHelp = new QMenu(tr("Help")); + auto menuHelp = new QMenu(tr("Help"), this); menuHelp->addAction(m_actionAbout); menuHelp->addAction(m_actionReportBug); menuHelp->addSeparator();