From a120441a100751eeb9a62bcd6d6dd82725273eba Mon Sep 17 00:00:00 2001 From: sithlord48 Date: Fri, 10 Oct 2025 15:52:49 -0400 Subject: [PATCH] refactor: CoreProcess::processModeToString use QVariant::fromValue().toString().toLower() to create the string, make method static member of CoreProcess --- src/lib/gui/core/CoreProcess.cpp | 12 ++---------- src/lib/gui/core/CoreProcess.h | 1 + 2 files changed, 3 insertions(+), 10 deletions(-) diff --git a/src/lib/gui/core/CoreProcess.cpp b/src/lib/gui/core/CoreProcess.cpp index ab16ae318..e9b2b239c 100644 --- a/src/lib/gui/core/CoreProcess.cpp +++ b/src/lib/gui/core/CoreProcess.cpp @@ -35,17 +35,9 @@ const auto kLineSplitRegex = QRegularExpression("\r|\n|\r\n"); // free functions // -QString processModeToString(Settings::ProcessMode mode) +QString CoreProcess::processModeToString(const Settings::ProcessMode mode) { - switch (mode) { - case Settings::ProcessMode::Desktop: - return "desktop"; - case Settings::ProcessMode::Service: - return "service"; - default: - qFatal("invalid process mode"); - abort(); - } + return QVariant::fromValue(mode).toString().toLower(); } QString processStateToString(CoreProcess::ProcessState state) diff --git a/src/lib/gui/core/CoreProcess.h b/src/lib/gui/core/CoreProcess.h index 6c861812e..6cdc2b836 100644 --- a/src/lib/gui/core/CoreProcess.h +++ b/src/lib/gui/core/CoreProcess.h @@ -125,6 +125,7 @@ private: QString requestDaemonLogPath(); void persistLogDir() const; static QString makeQuotedArgs(const QString &app, const QStringList &args); + static QString processModeToString(const Settings::ProcessMode mode); #ifdef Q_OS_MAC void checkOSXNotification(const QString &line);