From 9e94a4fe0e3d4381efac01090ac259511254e67f Mon Sep 17 00:00:00 2001
From: sithlord48 <sithlord48@gmail.com>
Date: Fri, 10 Oct 2025 14:49:38 -0400
Subject: [PATCH] refactor: CoreProcess::start, early return if process is
 already started

---
 src/lib/gui/core/CoreProcess.cpp | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/src/lib/gui/core/CoreProcess.cpp b/src/lib/gui/core/CoreProcess.cpp
index fac7ed578..15005d936 100644
--- a/src/lib/gui/core/CoreProcess.cpp
+++ b/src/lib/gui/core/CoreProcess.cpp
@@ -317,6 +317,11 @@ void CoreProcess::start(std::optional<ProcessMode> processModeOption)
 {
   using enum Settings::CoreMode;
 
+  if (m_processState == ProcessState::Started) {
+    qCritical("core process already started");
+    return;
+  }
+
   QMutexLocker locker(&m_processMutex);
 
   const auto currentMode = Settings::value(Settings::Core::ProcessMode).value<ProcessMode>();
@@ -325,11 +330,6 @@ void CoreProcess::start(std::optional<ProcessMode> processModeOption)
   qInfo().noquote(
   ) << QString("starting core %1 process (%2 mode)").arg(modeString(), processModeToString(processMode));
 
-  if (m_processState == ProcessState::Started) {
-    qCritical("core process already started");
-    return;
-  }
-
   // allow external listeners to abort the start process (e.g. licensing issue).
   setProcessState(ProcessState::Starting);
   Q_EMIT starting();