From 9976caafabb7931a8905a9af3f66ab87e1967aac Mon Sep 17 00:00:00 2001 From: sithlord48 Date: Sat, 27 Dec 2025 11:32:42 -0500 Subject: [PATCH] refactor: LineEditValidator only call errorMessage::isEmpty once --- src/lib/gui/validators/LineEditValidator.cpp | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/lib/gui/validators/LineEditValidator.cpp b/src/lib/gui/validators/LineEditValidator.cpp index 609be9492..989c44806 100644 --- a/src/lib/gui/validators/LineEditValidator.cpp +++ b/src/lib/gui/validators/LineEditValidator.cpp @@ -40,7 +40,9 @@ QValidator::State LineEditValidator::validate(QString &input, int &) const } } - if (errorMessage.isEmpty()) { + const bool isEmpty = errorMessage.isEmpty(); + + if (isEmpty) { m_pLineEdit->setStyleSheet({}); } else { // The values here are for fusion style int radius = 3; @@ -70,7 +72,7 @@ QValidator::State LineEditValidator::validate(QString &input, int &) const m_pError->setMessage(errorMessage); } - return errorMessage.isEmpty() ? Acceptable : Intermediate; + return isEmpty ? Acceptable : Intermediate; } } // namespace validators