From 9268fef89d2fd2229175c32f93d1a70771ba697d Mon Sep 17 00:00:00 2001 From: sithlord48 Date: Tue, 19 Aug 2025 22:28:18 -0400 Subject: [PATCH] refactor: SettingsDialog remove duplicate code by calling updateTlsControlsEnabled inside updateTlsControls --- src/lib/gui/dialogs/SettingsDialog.cpp | 11 +++-------- 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/src/lib/gui/dialogs/SettingsDialog.cpp b/src/lib/gui/dialogs/SettingsDialog.cpp index 2dd47cbf0..2084215a4 100644 --- a/src/lib/gui/dialogs/SettingsDialog.cpp +++ b/src/lib/gui/dialogs/SettingsDialog.cpp @@ -191,19 +191,14 @@ void SettingsDialog::updateTlsControls() ui->comboTlsKeyLength->setCurrentText(Settings::value(Settings::Security::KeySize).toString()); const auto tlsEnabled = Settings::value(Settings::Security::TlsEnabled).toBool(); - const auto writable = Settings::isWritable(); - const auto enabled = writable && tlsEnabled; ui->lineTlsCertPath->setText(certificate); ui->cbRequireClientCert->setChecked(Settings::value(Settings::Security::CheckPeers).toBool()); ui->groupSecurity->setChecked(tlsEnabled); - ui->groupSecurity->setEnabled(writable); - ui->comboTlsKeyLength->setEnabled(enabled); - ui->widgetTlsCert->setEnabled(enabled); - ui->lblTlsKeyLength->setEnabled(enabled); - ui->btnTlsRegenCert->setEnabled(enabled); - ui->cbRequireClientCert->setEnabled(enabled); + ui->groupSecurity->setEnabled(Settings::isWritable()); + + updateTlsControlsEnabled(); } void SettingsDialog::updateTlsControlsEnabled()