From 8dcd9b0c013778417ef691fbe2e2358cc12103df Mon Sep 17 00:00:00 2001 From: sithlord48 Date: Fri, 11 Jul 2025 13:18:05 -0400 Subject: [PATCH] refactor: ArgParser::assemble command use const ref std::string_view for ingoreArg --- src/lib/deskflow/ArgParser.cpp | 5 +++-- src/lib/deskflow/ArgParser.h | 6 ++++-- 2 files changed, 7 insertions(+), 4 deletions(-) diff --git a/src/lib/deskflow/ArgParser.cpp b/src/lib/deskflow/ArgParser.cpp index 83a782952..b054ca650 100644 --- a/src/lib/deskflow/ArgParser.cpp +++ b/src/lib/deskflow/ArgParser.cpp @@ -299,8 +299,9 @@ const char **ArgParser::getArgv(std::vector &argsArray) return argv; } -std::string -ArgParser::assembleCommand(std::vector &argsArray, std::string ignoreArg, int parametersRequired) +std::string ArgParser::assembleCommand( + std::vector &argsArray, const std::string_view &ignoreArg, int parametersRequired +) { std::string result; diff --git a/src/lib/deskflow/ArgParser.h b/src/lib/deskflow/ArgParser.h index 5ff0a208f..701ecad9c 100644 --- a/src/lib/deskflow/ArgParser.h +++ b/src/lib/deskflow/ArgParser.h @@ -40,8 +40,10 @@ public: static bool searchDoubleQuotes(const std::string_view &command, size_t &left, size_t &right, size_t startPos = 0); static void removeDoubleQuotes(std::string_view &arg); static const char **getArgv(std::vector &argsArray); - static std::string - assembleCommand(std::vector &argsArray, std::string ignoreArg = "", int parametersRequired = 0); + static std::string assembleCommand( + std::vector &argsArray, const std::string_view &ignoreArg = std::string_view(), + int parametersRequired = 0 + ); static deskflow::ArgsBase &argsBase() {