From 7d803071cac0b545cb83cf5748f451cbdfbbf1ff Mon Sep 17 00:00:00 2001
From: Serhii Hadzhilov <71632867+SerhiiGadzhilov@users.noreply.github.com>
Date: Tue, 26 Sep 2023 14:49:18 +0300
Subject: [PATCH] Change session ID info log message to DEBUG2 (#7284)

* Change error to debug2 and add additional info

* Update ChangeLog

* Improved wording in ChangeLog for 1.14.7

* Apply markdown formatting to ChangeLog

* Fixed merge gone wrong

* Fixed further merge mistake

* Fixed order of new ChangeLog lines

---------

Co-authored-by: Nick Bolton <nick@symless.com>
---
 ChangeLog                             | 14 ++++++--------
 src/lib/platform/MSWindowsSession.cpp |  3 ++-
 2 files changed, 8 insertions(+), 9 deletions(-)

diff --git a/ChangeLog b/ChangeLog
index 662abf883..c8d41de97 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,17 +1,15 @@
 # 1.14.7
 
-Bug fixes:
-
-- #7265 Remove extra key press traces for Linux
-
 Enhancements:
 
+- #7254 Bind client to a network interface with --address
 - #7262 Backward compatibility for M1 and M2 builds
-- #7254 Ability to bind client to a network interface
 - #7263 Change name of Flatpak uploaded to snapshots
-- #7269 Reword file drag drop error to debug message
-- #7274 Only build necessary binaries
-- #7277 Change start errors to fatal
+- #7265 Remove obtrusive Linux key press log messages
+- #7269 Change file drag drop ERROR to DEBUG message
+- #7274 Support env var to build unified core binary
+- #7277 Change all errors that cause crash are FATAL
+- #7284 Change session ID info log message to DEBUG2
 
 CI changes:
 
diff --git a/src/lib/platform/MSWindowsSession.cpp b/src/lib/platform/MSWindowsSession.cpp
index ebff081b0..7e794be48 100644
--- a/src/lib/platform/MSWindowsSession.cpp
+++ b/src/lib/platform/MSWindowsSession.cpp
@@ -70,7 +70,8 @@ MSWindowsSession::isProcessInSession(const char* name, PHANDLE process = NULL)
             if (!pidToSidRet) {
                 // if we can not acquire session associated with a specified process,
                 // simply ignore it
-                LOG((CLOG_ERR "could not get session id for process id %i", entry.th32ProcessID));
+                LOG((CLOG_DEBUG2 "could not get session id for process: %i %s, code=%i",
+                     entry.th32ProcessID, entry.szExeFile, GetLastError()));
                 gotEntry = nextProcessEntry(snapshot, &entry);
                 continue;
             }