From 5e347d8725b3d95c0b580a480c2342e6e92c1e17 Mon Sep 17 00:00:00 2001 From: sithlord48 Date: Fri, 12 Dec 2025 20:43:39 -0500 Subject: [PATCH] fix: Mac os log file not working fixes: #9274 The log file path is not able to be empty since Settings::value will return the default path if it is, Do not send a c_str to create our FileLogger it wants a QString --- src/lib/deskflow/App.cpp | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/src/lib/deskflow/App.cpp b/src/lib/deskflow/App.cpp index 8b1b0bae0..529f6abd1 100644 --- a/src/lib/deskflow/App.cpp +++ b/src/lib/deskflow/App.cpp @@ -110,12 +110,10 @@ int App::daemonMainLoop(int, const char **) void App::setupFileLogging() { if (Settings::value(Settings::Log::ToFile).toBool()) { - if (const auto file = Settings::value(Settings::Log::File).toString(); !file.isEmpty()) { - const auto logFile = qPrintable(file); - m_fileLog = new FileLogOutputter(logFile); // NOSONAR - Adopted by `Log` - CLOG->insert(m_fileLog); - LOG_DEBUG1("logging to file (%s) enabled", logFile); - } + const auto file = Settings::value(Settings::Log::File).toString(); + m_fileLog = new FileLogOutputter(file); // NOSONAR - Adopted by `Log` + CLOG->insert(m_fileLog); + LOG_DEBUG1("logging to file (%s) enabled", qPrintable(file)); } }