From 53b9c0908e53656996bd58cf4e84a44bcddf31fa Mon Sep 17 00:00:00 2001 From: Pedro Navarro Date: Sat, 7 Dec 2024 17:05:37 -0800 Subject: [PATCH] fix: Windows, avoid encoding empty data to the clipboard Do not attempt to convert null data to clipboard format and exit early --- src/lib/platform/MSWindowsClipboard.cpp | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/src/lib/platform/MSWindowsClipboard.cpp b/src/lib/platform/MSWindowsClipboard.cpp index a4740e576..4efe71a88 100644 --- a/src/lib/platform/MSWindowsClipboard.cpp +++ b/src/lib/platform/MSWindowsClipboard.cpp @@ -96,6 +96,11 @@ bool MSWindowsClipboard::empty() void MSWindowsClipboard::add(EFormat format, const String &data) { + // exit early if there is no data to prevent spurious "failed to convert clipboard data" errors + if (data.empty()) { + LOG((CLOG_DEBUG "not adding 0 bytes to clipboard format: %d", format)); + return; + } bool isSucceeded = false; // convert data to win32 form for (ConverterList::const_iterator index = m_converters.begin(); index != m_converters.end(); ++index) {