From 4f9b042f5a95ae128e229bf5e69c31b46abaeb48 Mon Sep 17 00:00:00 2001 From: sithlord48 Date: Fri, 1 Aug 2025 15:18:33 -0400 Subject: [PATCH] refactor: explicit constructor for PlatformScreen, FileTail, FunctionJob, FunctionEventJob, ServerConfig, ScreenSettingsDialog, KeySequenceWidget, NetworkAddress, AddClientDialog, ConfigReadContext, LockCursorToScreenAction, RestartServer And KeyboardBroadcastAction --- src/lib/base/FunctionEventJob.h | 2 +- src/lib/base/FunctionJob.h | 2 +- src/lib/deskflow/PlatformScreen.h | 2 +- src/lib/gui/FileTail.h | 2 +- src/lib/gui/ServerConfig.h | 2 +- src/lib/gui/dialogs/AddClientDialog.h | 2 +- src/lib/gui/dialogs/ScreenSettingsDialog.h | 2 +- src/lib/gui/widgets/KeySequenceWidget.h | 2 +- src/lib/net/NetworkAddress.h | 2 +- src/lib/server/Config.h | 2 +- src/lib/server/InputFilter.h | 8 ++++---- 11 files changed, 14 insertions(+), 14 deletions(-) diff --git a/src/lib/base/FunctionEventJob.h b/src/lib/base/FunctionEventJob.h index cd8b514fa..aa0076773 100644 --- a/src/lib/base/FunctionEventJob.h +++ b/src/lib/base/FunctionEventJob.h @@ -17,7 +17,7 @@ class FunctionEventJob : public IEventJob { public: //! run() invokes \c func(arg) - FunctionEventJob(void (*func)(const Event &, void *), void *arg = nullptr); + explicit FunctionEventJob(void (*func)(const Event &, void *), void *arg = nullptr); ~FunctionEventJob() override = default; // IEventJob overrides diff --git a/src/lib/base/FunctionJob.h b/src/lib/base/FunctionJob.h index bdaa5eeea..c7de2ad89 100644 --- a/src/lib/base/FunctionJob.h +++ b/src/lib/base/FunctionJob.h @@ -17,7 +17,7 @@ class FunctionJob : public IJob { public: //! run() invokes \c func(arg) - FunctionJob(void (*func)(void *), void *arg = nullptr); + explicit FunctionJob(void (*func)(void *), void *arg = nullptr); ~FunctionJob() override = default; // IJob overrides diff --git a/src/lib/deskflow/PlatformScreen.h b/src/lib/deskflow/PlatformScreen.h index 48e843216..e5f611f94 100644 --- a/src/lib/deskflow/PlatformScreen.h +++ b/src/lib/deskflow/PlatformScreen.h @@ -21,7 +21,7 @@ subclasses to implement the rest. class PlatformScreen : public IPlatformScreen { public: - PlatformScreen( + explicit PlatformScreen( IEventQueue *events, deskflow::ClientScrollDirection scrollDirection = deskflow::ClientScrollDirection::Normal ); ~PlatformScreen() override = default; diff --git a/src/lib/gui/FileTail.h b/src/lib/gui/FileTail.h index 125d2d2d4..c72681ce5 100644 --- a/src/lib/gui/FileTail.h +++ b/src/lib/gui/FileTail.h @@ -18,7 +18,7 @@ class FileTail : public QObject Q_OBJECT public: - FileTail(const QString &filePath, QObject *parent = nullptr); + explicit FileTail(const QString &filePath, QObject *parent = nullptr); Q_SIGNALS: void newLine(const QString &line); diff --git a/src/lib/gui/ServerConfig.h b/src/lib/gui/ServerConfig.h index 98cc4be30..11fc1fe0e 100644 --- a/src/lib/gui/ServerConfig.h +++ b/src/lib/gui/ServerConfig.h @@ -46,7 +46,7 @@ class ServerConfig : public ScreenConfig, public deskflow::gui::IServerConfig friend QTextStream &operator<<(QTextStream &outStream, const ServerConfig &config); public: - ServerConfig(MainWindow &mainWindow, int columns = kDefaultColumns, int rows = kDefaultRows); + explicit ServerConfig(MainWindow &mainWindow, int columns = kDefaultColumns, int rows = kDefaultRows); ~ServerConfig() override = default; bool operator==(const ServerConfig &sc) const; diff --git a/src/lib/gui/dialogs/AddClientDialog.h b/src/lib/gui/dialogs/AddClientDialog.h index d232427d3..5a84da08d 100644 --- a/src/lib/gui/dialogs/AddClientDialog.h +++ b/src/lib/gui/dialogs/AddClientDialog.h @@ -29,7 +29,7 @@ class AddClientDialog : public QDialog { Q_OBJECT public: - AddClientDialog(const QString &clientName, QWidget *parent = nullptr); + explicit AddClientDialog(const QString &clientName, QWidget *parent = nullptr); ~AddClientDialog() override; AddAction addResult() const diff --git a/src/lib/gui/dialogs/ScreenSettingsDialog.h b/src/lib/gui/dialogs/ScreenSettingsDialog.h index 8c4141ee1..a9407a2d4 100644 --- a/src/lib/gui/dialogs/ScreenSettingsDialog.h +++ b/src/lib/gui/dialogs/ScreenSettingsDialog.h @@ -24,7 +24,7 @@ class ScreenSettingsDialog : public QDialog Q_OBJECT public: - ScreenSettingsDialog(QWidget *parent, Screen *pScreen = nullptr, const ScreenList *pScreens = nullptr); + explicit ScreenSettingsDialog(QWidget *parent, Screen *pScreen = nullptr, const ScreenList *pScreens = nullptr); ~ScreenSettingsDialog() override; public Q_SLOTS: diff --git a/src/lib/gui/widgets/KeySequenceWidget.h b/src/lib/gui/widgets/KeySequenceWidget.h index ec5d2573e..06e44958d 100644 --- a/src/lib/gui/widgets/KeySequenceWidget.h +++ b/src/lib/gui/widgets/KeySequenceWidget.h @@ -16,7 +16,7 @@ class KeySequenceWidget : public QPushButton Q_OBJECT public: - KeySequenceWidget(QWidget *parent, const KeySequence &seq = KeySequence()); + explicit KeySequenceWidget(QWidget *parent, const KeySequence &seq = KeySequence()); Q_SIGNALS: void keySequenceChanged(); diff --git a/src/lib/net/NetworkAddress.h b/src/lib/net/NetworkAddress.h index b3b317778..6db741090 100644 --- a/src/lib/net/NetworkAddress.h +++ b/src/lib/net/NetworkAddress.h @@ -38,7 +38,7 @@ public: is thrown with an error of \c XSocketAddress::kBadPort. The hostname is not resolved by the c'tor; use \c resolve to do that. */ - NetworkAddress(const std::string &hostname, int port = 0); + explicit NetworkAddress(const std::string &hostname, int port = 0); NetworkAddress(const NetworkAddress &); diff --git a/src/lib/server/Config.h b/src/lib/server/Config.h index 826ed0ef8..b5041fcb8 100644 --- a/src/lib/server/Config.h +++ b/src/lib/server/Config.h @@ -488,7 +488,7 @@ class ConfigReadContext public: using ArgList = std::vector; - ConfigReadContext(std::istream &, int32_t firstLine = 1); + explicit ConfigReadContext(std::istream &, int32_t firstLine = 1); ~ConfigReadContext() = default; bool readLine(std::string &); diff --git a/src/lib/server/InputFilter.h b/src/lib/server/InputFilter.h index 5e7e6e878..b0839b635 100644 --- a/src/lib/server/InputFilter.h +++ b/src/lib/server/InputFilter.h @@ -139,7 +139,7 @@ public: kToggle }; - LockCursorToScreenAction(IEventQueue *events, Mode = kToggle); + explicit LockCursorToScreenAction(IEventQueue *events, Mode = kToggle); Mode getMode() const; @@ -161,7 +161,7 @@ public: restart }; - RestartServer(IEventQueue *events, Mode = restart); + explicit RestartServer(IEventQueue *events, Mode = restart); Mode getMode() const; @@ -222,8 +222,8 @@ public: kToggle }; - KeyboardBroadcastAction(IEventQueue *events, Mode = kToggle); - KeyboardBroadcastAction(IEventQueue *events, Mode, const std::set &screens); + explicit KeyboardBroadcastAction(IEventQueue *events, Mode = kToggle); + explicit KeyboardBroadcastAction(IEventQueue *events, Mode, const std::set &screens); Mode getMode() const; std::set getScreens() const;