From 4e641adae91f437d438fe2d2e0957313ecbac57d Mon Sep 17 00:00:00 2001 From: sithlord48 Date: Mon, 23 Feb 2026 22:32:32 -0500 Subject: [PATCH] refactor: ComputerNameValidator define regex static where used --- src/lib/gui/validators/ComputerNameValidator.cpp | 4 +++- src/lib/gui/validators/ComputerNameValidator.h | 6 ------ 2 files changed, 3 insertions(+), 7 deletions(-) diff --git a/src/lib/gui/validators/ComputerNameValidator.cpp b/src/lib/gui/validators/ComputerNameValidator.cpp index 194b45d11..175b9146f 100644 --- a/src/lib/gui/validators/ComputerNameValidator.cpp +++ b/src/lib/gui/validators/ComputerNameValidator.cpp @@ -17,7 +17,9 @@ ComputerNameValidator::ComputerNameValidator(const QString &message) : IStringVa bool ComputerNameValidator::validate(const QString &input) const { - auto match = m_nameValidator.match(input); + static const auto s_nameValidator = + QRegularExpression(QStringLiteral("^[\\w\\._-]{0,255}$"), QRegularExpression::CaseInsensitiveOption); + auto match = s_nameValidator.match(input); return match.hasMatch(); } diff --git a/src/lib/gui/validators/ComputerNameValidator.h b/src/lib/gui/validators/ComputerNameValidator.h index 2af8b76f1..a771517d7 100644 --- a/src/lib/gui/validators/ComputerNameValidator.h +++ b/src/lib/gui/validators/ComputerNameValidator.h @@ -8,8 +8,6 @@ #include "IStringValidator.h" -#include - namespace validators { class ComputerNameValidator : public IStringValidator @@ -17,10 +15,6 @@ class ComputerNameValidator : public IStringValidator public: explicit ComputerNameValidator(const QString &message); bool validate(const QString &input) const override; - -private: - inline static const QRegularExpression m_nameValidator = - QRegularExpression(QStringLiteral("^[\\w\\._-]{0,255}$"), QRegularExpression::CaseInsensitiveOption); }; } // namespace validators