From 4a92a3295b528a33e619789c57af4fe4c8ba1486 Mon Sep 17 00:00:00 2001 From: sithlord48 Date: Thu, 3 Jul 2025 09:03:14 -0400 Subject: [PATCH] refactor: ScreenSettingsDialog, do not create nested validators in the Lines setValidator method --- src/lib/gui/dialogs/ScreenSettingsDialog.cpp | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/src/lib/gui/dialogs/ScreenSettingsDialog.cpp b/src/lib/gui/dialogs/ScreenSettingsDialog.cpp index fff350a0b..e6d19dc6d 100644 --- a/src/lib/gui/dialogs/ScreenSettingsDialog.cpp +++ b/src/lib/gui/dialogs/ScreenSettingsDialog.cpp @@ -35,14 +35,15 @@ ScreenSettingsDialog::ScreenSettingsDialog(QWidget *parent, Screen *pScreen, con ui->m_pLabelNameError->setStyleSheet(kStyleErrorActiveLabel); ui->m_pLineEditName->setText(m_pScreen->name()); - ui->m_pLineEditName->setValidator(new validators::ScreenNameValidator( - ui->m_pLineEditName, new validators::ValidationError(this, ui->m_pLabelNameError), pScreens - )); + + auto valNameError = new validators::ValidationError(this, ui->m_pLabelNameError); + auto valName = new validators::ScreenNameValidator(ui->m_pLineEditName, valNameError, pScreens); + ui->m_pLineEditName->setValidator(valName); ui->m_pLineEditName->selectAll(); - ui->m_pLineEditAlias->setValidator(new validators::AliasValidator( - ui->m_pLineEditAlias, new validators::ValidationError(this, ui->m_pLabelAliasError) - )); + auto valAliasError = new validators::ValidationError(this, ui->m_pLabelAliasError); + auto valAlias = new validators::AliasValidator(ui->m_pLineEditAlias, valAliasError); + ui->m_pLineEditAlias->setValidator(valAlias); for (int i = 0; i < m_pScreen->aliases().count(); i++) new QListWidgetItem(m_pScreen->aliases()[i], ui->m_pListAliases);