From 49589ae4aa835c48b40212a277eca6b97807d042 Mon Sep 17 00:00:00 2001
From: Tomaz Canabrava <tcanabrava@kde.org>
Date: Thu, 8 May 2025 12:48:10 +0200
Subject: [PATCH] refactor, Modifiers, Use enum instead of cast to int

---
 src/lib/gui/config/Screen.h                  |  4 ++--
 src/lib/gui/dialogs/ScreenSettingsDialog.cpp | 10 +++++-----
 2 files changed, 7 insertions(+), 7 deletions(-)

diff --git a/src/lib/gui/config/Screen.h b/src/lib/gui/config/Screen.h
index b5f80415d..a877a1070 100644
--- a/src/lib/gui/config/Screen.h
+++ b/src/lib/gui/config/Screen.h
@@ -121,9 +121,9 @@ protected:
   {
     return m_Aliases;
   }
-  void setModifier(int m, int n)
+  void setModifier(Modifier m, int n)
   {
-    m_Modifiers[m] = n;
+    m_Modifiers[static_cast<int8_t>(m)] = n;
   }
   QList<int> &modifiers()
   {
diff --git a/src/lib/gui/dialogs/ScreenSettingsDialog.cpp b/src/lib/gui/dialogs/ScreenSettingsDialog.cpp
index 0581a5bd4..1ab6fe3f2 100644
--- a/src/lib/gui/dialogs/ScreenSettingsDialog.cpp
+++ b/src/lib/gui/dialogs/ScreenSettingsDialog.cpp
@@ -96,11 +96,11 @@ void ScreenSettingsDialog::accept()
     m_pScreen->addAlias(alias);
   }
 
-  m_pScreen->setModifier(static_cast<int>(Shift), ui_->m_pComboBoxShift->currentIndex());
-  m_pScreen->setModifier(static_cast<int>(Ctrl), ui_->m_pComboBoxCtrl->currentIndex());
-  m_pScreen->setModifier(static_cast<int>(Alt), ui_->m_pComboBoxAlt->currentIndex());
-  m_pScreen->setModifier(static_cast<int>(Meta), ui_->m_pComboBoxMeta->currentIndex());
-  m_pScreen->setModifier(static_cast<int>(Super), ui_->m_pComboBoxSuper->currentIndex());
+  m_pScreen->setModifier(Shift, ui_->m_pComboBoxShift->currentIndex());
+  m_pScreen->setModifier(Ctrl, ui_->m_pComboBoxCtrl->currentIndex());
+  m_pScreen->setModifier(Alt, ui_->m_pComboBoxAlt->currentIndex());
+  m_pScreen->setModifier(Meta, ui_->m_pComboBoxMeta->currentIndex());
+  m_pScreen->setModifier(Super, ui_->m_pComboBoxSuper->currentIndex());
 
   m_pScreen->setSwitchCorner(static_cast<int>(TopLeft), ui_->m_pCheckBoxCornerTopLeft->isChecked());
   m_pScreen->setSwitchCorner(static_cast<int>(TopRight), ui_->m_pCheckBoxCornerTopRight->isChecked());