From 45090d6b85a9546aa4b8c89f1b251ed7eefd88cf Mon Sep 17 00:00:00 2001
From: sithlord48 <sithlord48@gmail.com>
Date: Thu, 22 May 2025 16:24:32 -0400
Subject: [PATCH] chore: IArchString clean up remaing code smells

---
 src/lib/arch/IArchString.cpp | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/src/lib/arch/IArchString.cpp b/src/lib/arch/IArchString.cpp
index 023d56191..164ed2745 100644
--- a/src/lib/arch/IArchString.cpp
+++ b/src/lib/arch/IArchString.cpp
@@ -59,11 +59,10 @@ int IArchString::convStringWCToMB(char *dst, const wchar_t *src, uint32_t n, boo
       len += mblen - 1;
     }
   } else {
-    char *dst0 = dst;
+    const char *dst0 = dst;
     const wchar_t *scan = src;
     for (; n > 0; --n) {
-      ptrdiff_t mblen = wctomb(dst, *scan);
-      if (mblen == -1) {
+      if (ptrdiff_t mblen = wctomb(dst, *scan); mblen == -1) {
         *errors = true;
         *dst++ = '?';
       } else {
@@ -134,7 +133,7 @@ int IArchString::convStringMBToWC(wchar_t *dst, const char *src, uint32_t n, boo
       }
     }
   } else {
-    wchar_t *dst0 = dst;
+    const wchar_t *dst0 = dst;
     const char *scan = src;
     while (n > 0) {
       switch (ptrdiff_t mblen = mbtowc(dst, scan, n); mblen) {