From 3e76a393264cb240de9e9549a8edd2e55f8a9d4a Mon Sep 17 00:00:00 2001 From: Vasily Galkin Date: Wed, 5 Nov 2025 07:34:06 -0500 Subject: [PATCH] chore: remove unused IEventQueue::isEmpty port: https://github.com/debauchee/barrier/pull/656/commits/8ab6ad64f9a570a5529f77dd2e99175bf46995d0 --- src/lib/base/EventQueue.cpp | 5 ----- src/lib/base/EventQueue.h | 1 - src/lib/base/IEventQueue.h | 7 ------- src/unittests/legacytests/mock/deskflow/MockEventQueue.h | 1 - 4 files changed, 14 deletions(-) diff --git a/src/lib/base/EventQueue.cpp b/src/lib/base/EventQueue.cpp index b2e402479..6b572d5ed 100644 --- a/src/lib/base/EventQueue.cpp +++ b/src/lib/base/EventQueue.cpp @@ -286,11 +286,6 @@ void EventQueue::removeHandlers(void *target) } } -bool EventQueue::isEmpty() const -{ - return (m_buffer->isEmpty() && getNextTimerTimeout() != 0.0); -} - const EventQueue::EventHandler *EventQueue::getHandler(EventTypes type, void *target) const { std::scoped_lock lock{m_mutex}; diff --git a/src/lib/base/EventQueue.h b/src/lib/base/EventQueue.h index 772d51b52..3886c75cb 100644 --- a/src/lib/base/EventQueue.h +++ b/src/lib/base/EventQueue.h @@ -47,7 +47,6 @@ public: void addHandler(EventTypes type, void *target, const EventHandler &handler) override; void removeHandler(EventTypes type, void *target) override; void removeHandlers(void *target) override; - bool isEmpty() const override; void *getSystemTarget() override; void waitForReady() const override; diff --git a/src/lib/base/IEventQueue.h b/src/lib/base/IEventQueue.h index a5bb63b1a..da963a1b5 100644 --- a/src/lib/base/IEventQueue.h +++ b/src/lib/base/IEventQueue.h @@ -152,13 +152,6 @@ public: //! @name accessors //@{ - //! Test if queue is empty - /*! - Returns true iff the queue has no events in it, including timer - events. - */ - virtual bool isEmpty() const = 0; - //! Get the system event type target /*! Returns the target to use for dispatching \c EventTypes::System events. diff --git a/src/unittests/legacytests/mock/deskflow/MockEventQueue.h b/src/unittests/legacytests/mock/deskflow/MockEventQueue.h index 1945b792a..7d1903ac3 100644 --- a/src/unittests/legacytests/mock/deskflow/MockEventQueue.h +++ b/src/unittests/legacytests/mock/deskflow/MockEventQueue.h @@ -21,7 +21,6 @@ public: MOCK_METHOD(void, adoptBuffer, (IEventQueueBuffer *), (override)); MOCK_METHOD(void, removeHandlers, (void *), (override)); MOCK_METHOD(EventTypes, registerType, (const char *)); - MOCK_METHOD(bool, isEmpty, (), (const, override)); MOCK_METHOD(void, addHandler, (EventTypes, void *, const EventHandler &), (override)); MOCK_METHOD(void, addEvent, (const Event &), (override)); MOCK_METHOD(void, removeHandler, (EventTypes, void *), (override));