chore: add comment to empty methods

This commit is contained in:
sithlord48
2025-05-20 10:39:18 -04:00
committed by Nick Bolton
parent 52b0c1f061
commit 3cf0fb89ef
41 changed files with 46 additions and 1 deletions

View File

@ -65,7 +65,6 @@ static in_addr_t inet_aton(const char *cp, struct in_addr *inp)
void ArchNetworkBSD::Deps::sleep(double seconds) void ArchNetworkBSD::Deps::sleep(double seconds)
{ {
//
ARCH->sleep(seconds); ARCH->sleep(seconds);
} }

View File

@ -55,6 +55,7 @@ class ArchNetAddressImpl
public: public:
ArchNetAddressImpl() : m_len(sizeof(m_addr)) ArchNetAddressImpl() : m_len(sizeof(m_addr))
{ {
// do nothing
} }
public: public:

View File

@ -15,6 +15,7 @@ class XArchEvalUnix : public XArchEval
public: public:
explicit XArchEvalUnix(int error) : m_error(error) explicit XArchEvalUnix(int error) : m_error(error)
{ {
// do nothing
} }
~XArchEvalUnix() noexcept override = default; ~XArchEvalUnix() noexcept override = default;

View File

@ -33,6 +33,7 @@ Event::Event(EventTypes type, void *target, EventData *dataObject)
m_flags(kNone), m_flags(kNone),
m_dataObject(dataObject) m_dataObject(dataObject)
{ {
// do nothing
} }
EventTypes Event::getType() const EventTypes Event::getType() const

View File

@ -19,6 +19,7 @@ public:
explicit FinalAction(Callable callable) noexcept : m_callable{callable} explicit FinalAction(Callable callable) noexcept : m_callable{callable}
{ {
// do nothing
} }
~FinalAction() noexcept ~FinalAction() noexcept

View File

@ -45,6 +45,7 @@ public:
public: public:
FailInfo(const char *what) : m_retry(false), m_what(what) FailInfo(const char *what) : m_retry(false), m_what(what)
{ {
// do nothing
} }
bool m_retry; bool m_retry;
std::string m_what; std::string m_what;

View File

@ -25,6 +25,7 @@ public:
: m_invalidHello(std::move(invalidHello)), : m_invalidHello(std::move(invalidHello)),
m_incompatible(std::move(incompatible)) m_incompatible(std::move(incompatible))
{ {
// do nothing
} }
virtual ~Deps() = default; virtual ~Deps() = default;
@ -51,6 +52,7 @@ public:
m_majorVersion(majorVersion), m_majorVersion(majorVersion),
m_minorVersion(minorVersion) m_minorVersion(minorVersion)
{ {
// do nothing
} }
/** /**

View File

@ -37,6 +37,7 @@ public:
public: public:
XNoEiSupport() : std::runtime_error("libei is not supported") XNoEiSupport() : std::runtime_error("libei is not supported")
{ {
// do nothing
} }
}; };

View File

@ -66,6 +66,7 @@ ClientApp::ClientApp(IEventQueue *events)
m_clientScreen(nullptr), m_clientScreen(nullptr),
m_serverAddress(nullptr) m_serverAddress(nullptr)
{ {
// do nothing
} }
void ClientApp::parseArgs(int argc, const char *const *argv) void ClientApp::parseArgs(int argc, const char *const *argv)

View File

@ -36,6 +36,7 @@ public:
const char *daemonInfo() const override; const char *daemonInfo() const override;
void loadConfig() override void loadConfig() override
{ {
// do nothing
} }
bool loadConfig(const std::string &pathname) override bool loadConfig(const std::string &pathname) override
{ {

View File

@ -20,6 +20,7 @@ namespace deskflow {
Config::Config(const std::string &filename, const std::string &section) : m_filename(filename), m_section(section) Config::Config(const std::string &filename, const std::string &section) : m_filename(filename), m_section(section)
{ {
// do nothing
} }
const char *const *Config::argv() const const char *const *Config::argv() const

View File

@ -28,6 +28,7 @@ public:
public: public:
explicit ParseError() : std::runtime_error("failed to parse config file") explicit ParseError() : std::runtime_error("failed to parse config file")
{ {
// do nothing
} }
}; };
@ -36,6 +37,7 @@ public:
public: public:
explicit NoConfigFilenameError() : std::runtime_error("no config file specified") explicit NoConfigFilenameError() : std::runtime_error("no config file specified")
{ {
// do nothing
} }
}; };

View File

@ -41,6 +41,7 @@ void showHelp(int argc, char **argv) // NOSONAR - CLI args
DaemonApp::DaemonApp(IEventQueue &events) : m_events(events) DaemonApp::DaemonApp(IEventQueue &events) : m_events(events)
{ {
// do nothing
} }
DaemonApp::~DaemonApp() = default; DaemonApp::~DaemonApp() = default;

View File

@ -14,9 +14,11 @@ class DisplayInvalidException : public std::runtime_error
public: public:
DisplayInvalidException(const char *msg) : std::runtime_error(msg) DisplayInvalidException(const char *msg) : std::runtime_error(msg)
{ {
// do nothing
} }
DisplayInvalidException(std::string msg) : std::runtime_error(msg) DisplayInvalidException(std::string msg) : std::runtime_error(msg)
{ {
// do nothing
} }
}; };

View File

@ -17,6 +17,7 @@
IKeyState::IKeyState(IEventQueue *events) IKeyState::IKeyState(IEventQueue *events)
{ {
// do nothing
} }
// //

View File

@ -30,6 +30,7 @@ public:
IPlatformScreen(IEventQueue *events) : IKeyState(events) IPlatformScreen(IEventQueue *events) : IKeyState(events)
{ {
// do nothing
} }
//! Enable screen //! Enable screen

View File

@ -13,6 +13,7 @@ PlatformScreen::PlatformScreen(IEventQueue *events, deskflow::ClientScrollDirect
: IPlatformScreen(events), : IPlatformScreen(events),
m_clientScrollDirection(scrollDirection) m_clientScrollDirection(scrollDirection)
{ {
// do nothing
} }
void PlatformScreen::updateKeyMap() void PlatformScreen::updateKeyMap()

View File

@ -22,6 +22,7 @@ DaemonIpcServer::DaemonIpcServer(QObject *parent, const QString &logFilename)
m_logFilename(logFilename), m_logFilename(logFilename),
m_server{new QLocalServer(this)} // NOSONAR - Qt memory m_server{new QLocalServer(this)} // NOSONAR - Qt memory
{ {
// do nothing
} }
DaemonIpcServer::~DaemonIpcServer() DaemonIpcServer::~DaemonIpcServer()

View File

@ -25,6 +25,7 @@
AppUtilUnix::AppUtilUnix(IEventQueue *events) AppUtilUnix::AppUtilUnix(IEventQueue *events)
{ {
// do nothing
} }
int standardStartupStatic(int argc, char **argv) int standardStartupStatic(int argc, char **argv)

View File

@ -12,6 +12,7 @@
Hotkey::Hotkey() : m_keySequence{}, m_actions{} Hotkey::Hotkey() : m_keySequence{}, m_actions{}
{ {
// do nothing
} }
QString Hotkey::text() const QString Hotkey::text() const

View File

@ -32,6 +32,7 @@ public:
: m_pParent(parent), : m_pParent(parent),
m_deps(deps) m_deps(deps)
{ {
// do nothing
} }
void handleLogLine(const QString &line); void handleLogLine(const QString &line);

View File

@ -13,6 +13,7 @@ CommandProcess::CommandProcess(QString command, QStringList arguments, QString i
m_Arguments(arguments), m_Arguments(arguments),
m_Input(input) m_Input(input)
{ {
// do nothing
} }
QString CommandProcess::run() QString CommandProcess::run()

View File

@ -10,6 +10,7 @@ namespace deskflow::gui {
ServerMessage::ServerMessage(const QString &message) : m_message(message), m_clientName(parseClientName(message)) ServerMessage::ServerMessage(const QString &message) : m_message(message), m_clientName(parseClientName(message))
{ {
// do nothing
} }
bool ServerMessage::isNewClientMessage() const bool ServerMessage::isNewClientMessage() const

View File

@ -25,6 +25,7 @@
TlsCertificate::TlsCertificate(QObject *parent) : QObject(parent) TlsCertificate::TlsCertificate(QObject *parent) : QObject(parent)
{ {
// do nothing
} }
bool TlsCertificate::generateCertificate(const QString &path, int keyLength) bool TlsCertificate::generateCertificate(const QString &path, int keyLength)

View File

@ -15,6 +15,7 @@ namespace deskflow::gui {
TlsUtility::TlsUtility(QObject *parent) : QObject(parent) TlsUtility::TlsUtility(QObject *parent) : QObject(parent)
{ {
// do nothing
} }
bool TlsUtility::isEnabled() const bool TlsUtility::isEnabled() const

View File

@ -12,6 +12,7 @@ namespace validators {
ComputerNameValidator::ComputerNameValidator(const QString &message) : IStringValidator(message) ComputerNameValidator::ComputerNameValidator(const QString &message) : IStringValidator(message)
{ {
// do nothing
} }
bool ComputerNameValidator::validate(const QString &input) const bool ComputerNameValidator::validate(const QString &input) const

View File

@ -10,6 +10,7 @@ namespace validators {
EmptyStringValidator::EmptyStringValidator(const QString &message) : IStringValidator(message) EmptyStringValidator::EmptyStringValidator(const QString &message) : IStringValidator(message)
{ {
// do nothing
} }
bool EmptyStringValidator::validate(const QString &input) const bool EmptyStringValidator::validate(const QString &input) const

View File

@ -10,6 +10,7 @@ namespace validators {
IStringValidator::IStringValidator(const QString &message) : m_Message(message) IStringValidator::IStringValidator(const QString &message) : m_Message(message)
{ {
// do nothing
} }
const QString &IStringValidator::getMessage() const const QString &IStringValidator::getMessage() const

View File

@ -15,6 +15,7 @@ ScreenDuplicationsValidator::ScreenDuplicationsValidator(
m_defaultName(defaultName), m_defaultName(defaultName),
m_pScreenList(pScreens) m_pScreenList(pScreens)
{ {
// do nothing
} }
bool ScreenDuplicationsValidator::validate(const QString &input) const bool ScreenDuplicationsValidator::validate(const QString &input) const

View File

@ -10,6 +10,7 @@ namespace validators {
SpacesValidator::SpacesValidator(const QString &message) : IStringValidator(message) SpacesValidator::SpacesValidator(const QString &message) : IStringValidator(message)
{ {
// do nothing
} }
bool SpacesValidator::validate(const QString &input) const bool SpacesValidator::validate(const QString &input) const

View File

@ -16,6 +16,7 @@
NewScreenWidget::NewScreenWidget(QWidget *parent) : QLabel(parent) NewScreenWidget::NewScreenWidget(QWidget *parent) : QLabel(parent)
{ {
// do nothing
} }
void NewScreenWidget::mousePressEvent(QMouseEvent *event) void NewScreenWidget::mousePressEvent(QMouseEvent *event)

View File

@ -20,6 +20,7 @@ class TrashScreenWidget : public QLabel
public: public:
TrashScreenWidget(QWidget *parent) : QLabel(parent) TrashScreenWidget(QWidget *parent) : QLabel(parent)
{ {
// do nothing
} }
public: public:

View File

@ -21,6 +21,7 @@ public:
//! \c result is the result of the thread //! \c result is the result of the thread
XThreadExit(void *result) : m_result(result) XThreadExit(void *result) : m_result(result)
{ {
// do nothing
} }
~XThreadExit() = default; ~XThreadExit() = default;

View File

@ -24,6 +24,7 @@ public:
public: public:
ConnectionFailedInfo(const char *what) : m_what(what) ConnectionFailedInfo(const char *what) : m_what(what)
{ {
// do nothing
} }
std::string m_what; std::string m_what;
}; };

View File

@ -29,6 +29,7 @@ SecureListenSocket::SecureListenSocket(
m_securityLevel{securityLevel} m_securityLevel{securityLevel}
{ {
// do nothing
} }
IDataSocket *SecureListenSocket::accept() IDataSocket *SecureListenSocket::accept()

View File

@ -65,6 +65,7 @@ SecureSocket::SecureSocket(
m_fatal(false), m_fatal(false),
m_securityLevel{securityLevel} m_securityLevel{securityLevel}
{ {
// do nothing
} }
SecureSocket::SecureSocket( SecureSocket::SecureSocket(
@ -76,6 +77,7 @@ SecureSocket::SecureSocket(
m_fatal(false), m_fatal(false),
m_securityLevel{securityLevel} m_securityLevel{securityLevel}
{ {
// do nothing
} }
SecureSocket::~SecureSocket() SecureSocket::~SecureSocket()

View File

@ -29,6 +29,7 @@ public:
// IEventQueueBuffer overrides // IEventQueueBuffer overrides
void init() override void init() override
{ {
// do nothing
} }
void waitForEvent(double timeout_in_ms) override; void waitForEvent(double timeout_in_ms) override;
Type getEvent(Event &event, uint32_t &dataID) override; Type getEvent(Event &event, uint32_t &dataID) override;

View File

@ -855,10 +855,12 @@ std::string EiScreen::getSecureInputApp() const
EiScreen::HotKeyItem::HotKeyItem(std::uint32_t mask, std::uint32_t id) : mask_(mask), id_(id) EiScreen::HotKeyItem::HotKeyItem(std::uint32_t mask, std::uint32_t id) : mask_(mask), id_(id)
{ {
// Todo: Implement
} }
EiScreen::HotKeySet::HotKeySet(KeyID key) : id_(key) EiScreen::HotKeySet::HotKeySet(KeyID key) : id_(key)
{ {
// Todo: Implement
} }
bool EiScreen::HotKeySet::remove_by_id(std::uint32_t id) bool EiScreen::HotKeySet::remove_by_id(std::uint32_t id)

View File

@ -18,6 +18,7 @@
ClientProxy::ClientProxy(const std::string &name, deskflow::IStream *stream) : BaseClientProxy(name), m_stream(stream) ClientProxy::ClientProxy(const std::string &name, deskflow::IStream *stream) : BaseClientProxy(name), m_stream(stream)
{ {
// do nothing
} }
ClientProxy::~ClientProxy() ClientProxy::~ClientProxy()

View File

@ -19,6 +19,7 @@ ClientProxy1_7::ClientProxy1_7(const std::string &name, deskflow::IStream *strea
: ClientProxy1_6(name, stream, server, events), : ClientProxy1_6(name, stream, server, events),
m_events(events) m_events(events)
{ {
// do nothing
} }
void ClientProxy1_7::secureInputNotification(const std::string &app) const void ClientProxy1_7::secureInputNotification(const std::string &app) const

View File

@ -148,9 +148,11 @@ public:
public: public:
explicit const_iterator() : m_i() explicit const_iterator() : m_i()
{ {
// do nothing
} }
explicit const_iterator(const internal_const_iterator &i) : m_i(i) explicit const_iterator(const internal_const_iterator &i) : m_i(i)
{ {
// do nothing
} }
const_iterator(const const_iterator &src) = default; const_iterator(const const_iterator &src) = default;
~const_iterator() = default; ~const_iterator() = default;