Format all source with Clang and introduce lint workflow (#7364)
* Lint script with CLang format * Use `-i` for `clang-format` and add more logging for lint scripts * Apply LLVM CLang formatting * Fixed comment * Update ChangeLog * Fixed bad return code logic * Improve output for linters * Fixed re-used var in clang lint * Fixed include order for tests and use `#if 0` instead of commenting out code * Use full Clang format dump * Dump Ubuntu Clang format * Dump Clang format from Debian * Dumped from: clang-format version 18.1.8 * Revert "Dumped from: clang-format version 18.1.8" This reverts commit b9bbda2995bb0b4b65baf14afebb0361ec64e644. * Remove BasedOnStyle * Restore base Clang format file * Use clang-format from pip * Apply Clang format 18 style * Add clang_format deps * Fixed include order issues and *some* accidental includes
This commit is contained in:
Nick Bolton
@ -1,11 +1,11 @@
|
||||
/*
|
||||
* synergy -- mouse and keyboard sharing utility
|
||||
* Copyright (C) 2014-2016 Symless Ltd.
|
||||
*
|
||||
*
|
||||
* This package is free software; you can redistribute it and/or
|
||||
* modify it under the terms of the GNU General Public License
|
||||
* found in the file LICENSE that should have accompanied this file.
|
||||
*
|
||||
*
|
||||
* This package is distributed in the hope that it will be useful,
|
||||
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
||||
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
||||
@ -21,157 +21,142 @@
|
||||
|
||||
using namespace synergy;
|
||||
|
||||
TEST(StringTests, format_formatWithArguments_formatedString)
|
||||
{
|
||||
const char* format = "%%%{1}=%{2}";
|
||||
const char* arg1 = "answer";
|
||||
const char* arg2 = "42";
|
||||
TEST(StringTests, format_formatWithArguments_formatedString) {
|
||||
const char *format = "%%%{1}=%{2}";
|
||||
const char *arg1 = "answer";
|
||||
const char *arg2 = "42";
|
||||
|
||||
String result = string::format(format, arg1, arg2);
|
||||
String result = string::format(format, arg1, arg2);
|
||||
|
||||
EXPECT_EQ("%answer=42", result);
|
||||
EXPECT_EQ("%answer=42", result);
|
||||
}
|
||||
|
||||
TEST(StringTests, findReplaceAll_inputString_replacedString)
|
||||
{
|
||||
String subject = "foobar";
|
||||
String find = "bar";
|
||||
String replace = "baz";
|
||||
TEST(StringTests, findReplaceAll_inputString_replacedString) {
|
||||
String subject = "foobar";
|
||||
String find = "bar";
|
||||
String replace = "baz";
|
||||
|
||||
string::findReplaceAll(subject, find, replace);
|
||||
string::findReplaceAll(subject, find, replace);
|
||||
|
||||
EXPECT_EQ("foobaz", subject);
|
||||
EXPECT_EQ("foobaz", subject);
|
||||
}
|
||||
|
||||
TEST(StringTests, sprintf_formatWithArgument_formatedString)
|
||||
{
|
||||
const char* format = "%s=%d";
|
||||
const char* arg1 = "answer";
|
||||
int arg2 = 42;
|
||||
TEST(StringTests, sprintf_formatWithArgument_formatedString) {
|
||||
const char *format = "%s=%d";
|
||||
const char *arg1 = "answer";
|
||||
int arg2 = 42;
|
||||
|
||||
String result = string::sprintf(format, arg1, arg2);
|
||||
String result = string::sprintf(format, arg1, arg2);
|
||||
|
||||
EXPECT_EQ("answer=42", result);
|
||||
EXPECT_EQ("answer=42", result);
|
||||
}
|
||||
|
||||
TEST(StringTests, toHex_plaintext_hexString)
|
||||
{
|
||||
String subject = "foobar";
|
||||
int width = 2;
|
||||
TEST(StringTests, toHex_plaintext_hexString) {
|
||||
String subject = "foobar";
|
||||
int width = 2;
|
||||
|
||||
string::toHex(subject, width);
|
||||
string::toHex(subject, width);
|
||||
|
||||
EXPECT_EQ("666f6f626172", subject);
|
||||
EXPECT_EQ("666f6f626172", subject);
|
||||
}
|
||||
|
||||
TEST(StringTests, uppercase_lowercaseInput_uppercaseOutput)
|
||||
{
|
||||
String subject = "12foo3BaR";
|
||||
TEST(StringTests, uppercase_lowercaseInput_uppercaseOutput) {
|
||||
String subject = "12foo3BaR";
|
||||
|
||||
string::uppercase(subject);
|
||||
string::uppercase(subject);
|
||||
|
||||
EXPECT_EQ("12FOO3BAR", subject);
|
||||
EXPECT_EQ("12FOO3BAR", subject);
|
||||
}
|
||||
|
||||
TEST(StringTests, removeChar_inputString_removeAllSpecifiedCharactors)
|
||||
{
|
||||
String subject = "foobar";
|
||||
const char c = 'o';
|
||||
TEST(StringTests, removeChar_inputString_removeAllSpecifiedCharactors) {
|
||||
String subject = "foobar";
|
||||
const char c = 'o';
|
||||
|
||||
string::removeChar(subject, c);
|
||||
string::removeChar(subject, c);
|
||||
|
||||
EXPECT_EQ("fbar", subject);
|
||||
EXPECT_EQ("fbar", subject);
|
||||
}
|
||||
|
||||
TEST(StringTests, intToString_inputInt_outputString)
|
||||
{
|
||||
size_t value = 123;
|
||||
TEST(StringTests, intToString_inputInt_outputString) {
|
||||
size_t value = 123;
|
||||
|
||||
String number = string::sizeTypeToString(value);
|
||||
String number = string::sizeTypeToString(value);
|
||||
|
||||
EXPECT_EQ("123", number);
|
||||
EXPECT_EQ("123", number);
|
||||
}
|
||||
|
||||
TEST(StringTests, stringToUint_inputString_outputInt)
|
||||
{
|
||||
String number = "123";
|
||||
TEST(StringTests, stringToUint_inputString_outputInt) {
|
||||
String number = "123";
|
||||
|
||||
size_t value = string::stringToSizeType(number);
|
||||
size_t value = string::stringToSizeType(number);
|
||||
|
||||
EXPECT_EQ(123, value);
|
||||
EXPECT_EQ(123, value);
|
||||
}
|
||||
|
||||
TEST(StringTests, splitString_twoSeparator_returnThreeParts)
|
||||
{
|
||||
String string = "stub1:stub2:stub3";
|
||||
TEST(StringTests, splitString_twoSeparator_returnThreeParts) {
|
||||
String string = "stub1:stub2:stub3";
|
||||
|
||||
std::vector<String> results = string::splitString(string, ':');
|
||||
std::vector<String> results = string::splitString(string, ':');
|
||||
|
||||
EXPECT_EQ(3, results.size());
|
||||
EXPECT_EQ("stub1", results[0]);
|
||||
EXPECT_EQ("stub2", results[1]);
|
||||
EXPECT_EQ("stub3", results[2]);
|
||||
EXPECT_EQ(3, results.size());
|
||||
EXPECT_EQ("stub1", results[0]);
|
||||
EXPECT_EQ("stub2", results[1]);
|
||||
EXPECT_EQ("stub3", results[2]);
|
||||
}
|
||||
|
||||
TEST(StringTests, splitString_oneSeparator_returnTwoParts)
|
||||
{
|
||||
String string = "stub1:stub2";
|
||||
TEST(StringTests, splitString_oneSeparator_returnTwoParts) {
|
||||
String string = "stub1:stub2";
|
||||
|
||||
std::vector<String> results = string::splitString(string, ':');
|
||||
std::vector<String> results = string::splitString(string, ':');
|
||||
|
||||
EXPECT_EQ(2, results.size());
|
||||
EXPECT_EQ("stub1", results[0]);
|
||||
EXPECT_EQ("stub2", results[1]);
|
||||
EXPECT_EQ(2, results.size());
|
||||
EXPECT_EQ("stub1", results[0]);
|
||||
EXPECT_EQ("stub2", results[1]);
|
||||
}
|
||||
|
||||
TEST(StringTests, splitString_noSeparator_returnOriginalString)
|
||||
{
|
||||
String string = "stub1";
|
||||
TEST(StringTests, splitString_noSeparator_returnOriginalString) {
|
||||
String string = "stub1";
|
||||
|
||||
std::vector<String> results = string::splitString(string, ':');
|
||||
std::vector<String> results = string::splitString(string, ':');
|
||||
|
||||
EXPECT_EQ(1, results.size());
|
||||
EXPECT_EQ("stub1", results[0]);
|
||||
EXPECT_EQ(1, results.size());
|
||||
EXPECT_EQ("stub1", results[0]);
|
||||
}
|
||||
|
||||
TEST(StringTests, splitString_emptyString_returnEmptyVector)
|
||||
{
|
||||
String string;
|
||||
TEST(StringTests, splitString_emptyString_returnEmptyVector) {
|
||||
String string;
|
||||
|
||||
std::vector<String> results = string::splitString(string, ':');
|
||||
std::vector<String> results = string::splitString(string, ':');
|
||||
|
||||
EXPECT_EQ(0, results.size());
|
||||
EXPECT_EQ(0, results.size());
|
||||
}
|
||||
|
||||
TEST(StringTests, splitString_tailSeparator_returnTwoParts)
|
||||
{
|
||||
String string = "stub1:stub2:";
|
||||
TEST(StringTests, splitString_tailSeparator_returnTwoParts) {
|
||||
String string = "stub1:stub2:";
|
||||
|
||||
std::vector<String> results = string::splitString(string, ':');
|
||||
std::vector<String> results = string::splitString(string, ':');
|
||||
|
||||
EXPECT_EQ(2, results.size());
|
||||
EXPECT_EQ("stub1", results[0]);
|
||||
EXPECT_EQ("stub2", results[1]);
|
||||
EXPECT_EQ(2, results.size());
|
||||
EXPECT_EQ("stub1", results[0]);
|
||||
EXPECT_EQ("stub2", results[1]);
|
||||
}
|
||||
|
||||
TEST(StringTests, splitString_headSeparator_returnTwoParts)
|
||||
{
|
||||
String string = ":stub1:stub2";
|
||||
TEST(StringTests, splitString_headSeparator_returnTwoParts) {
|
||||
String string = ":stub1:stub2";
|
||||
|
||||
std::vector<String> results = string::splitString(string, ':');
|
||||
std::vector<String> results = string::splitString(string, ':');
|
||||
|
||||
EXPECT_EQ(2, results.size());
|
||||
EXPECT_EQ("stub1", results[0]);
|
||||
EXPECT_EQ("stub2", results[1]);
|
||||
EXPECT_EQ(2, results.size());
|
||||
EXPECT_EQ("stub1", results[0]);
|
||||
EXPECT_EQ("stub2", results[1]);
|
||||
}
|
||||
|
||||
TEST(StringTests, splitString_headAndTailSeparators_returnTwoParts)
|
||||
{
|
||||
String string = ":stub1:stub2:";
|
||||
TEST(StringTests, splitString_headAndTailSeparators_returnTwoParts) {
|
||||
String string = ":stub1:stub2:";
|
||||
|
||||
std::vector<String> results = string::splitString(string, ':');
|
||||
std::vector<String> results = string::splitString(string, ':');
|
||||
|
||||
EXPECT_EQ(2, results.size());
|
||||
EXPECT_EQ("stub1", results[0]);
|
||||
EXPECT_EQ("stub2", results[1]);
|
||||
EXPECT_EQ(2, results.size());
|
||||
EXPECT_EQ("stub1", results[0]);
|
||||
EXPECT_EQ("stub2", results[1]);
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user