From 36e985d8abe0745330335035da159f52d58cd8d6 Mon Sep 17 00:00:00 2001 From: sithlord48 Date: Thu, 3 Jul 2025 19:43:56 -0400 Subject: [PATCH] chore: add missing default for switches --- src/lib/base/Unicode.cpp | 3 +++ src/lib/client/ServerProxy.cpp | 3 +++ src/lib/deskflow/ClipboardChunk.cpp | 3 +++ src/lib/deskflow/ProtocolUtil.cpp | 4 ++++ src/lib/gui/KeySequence.cpp | 3 +++ src/lib/gui/ScreenSetupModel.cpp | 3 +++ src/lib/platform/XWindowsScreen.cpp | 3 +++ src/lib/platform/XWindowsScreenSaver.cpp | 2 ++ src/lib/server/ClientProxyUnknown.cpp | 3 +++ 9 files changed, 27 insertions(+) diff --git a/src/lib/base/Unicode.cpp b/src/lib/base/Unicode.cpp index 0289dc0d3..233b57ca3 100644 --- a/src/lib/base/Unicode.cpp +++ b/src/lib/base/Unicode.cpp @@ -630,6 +630,9 @@ uint32_t Unicode::fromUTF8(const uint8_t *&data, uint32_t &n) truncated = true; size = 1; } + + default: + break; } // update parameters diff --git a/src/lib/client/ServerProxy.cpp b/src/lib/client/ServerProxy.cpp index 70e761645..9399388f3 100644 --- a/src/lib/client/ServerProxy.cpp +++ b/src/lib/client/ServerProxy.cpp @@ -441,6 +441,9 @@ KeyID ServerProxy::translateKey(KeyID id) const id2 = kKeyModifierIDSuper; side = 1; break; + + default: + break; } if (id2 != kKeyModifierIDNull) { diff --git a/src/lib/deskflow/ClipboardChunk.cpp b/src/lib/deskflow/ClipboardChunk.cpp index 1b88e4fa9..5e092f817 100644 --- a/src/lib/deskflow/ClipboardChunk.cpp +++ b/src/lib/deskflow/ClipboardChunk.cpp @@ -121,6 +121,9 @@ void ClipboardChunk::send(deskflow::IStream *stream, void *data) case ChunkType::DataEnd: LOG((CLOG_DEBUG2 "sending clipboard finished")); break; + + default: + break; } ProtocolUtil::writef(stream, kMsgDClipboard, id, sequence, mark, &dataChunk); diff --git a/src/lib/deskflow/ProtocolUtil.cpp b/src/lib/deskflow/ProtocolUtil.cpp index 53de04417..094e7f12e 100644 --- a/src/lib/deskflow/ProtocolUtil.cpp +++ b/src/lib/deskflow/ProtocolUtil.cpp @@ -255,6 +255,10 @@ uint32_t ProtocolUtil::getLength(const char *fmt, va_list args) case 4: len = 4 * (uint32_t)(va_arg(args, std::vector *))->size() + 4; break; + + default: + LOG((CLOG_ERR "format specifier %%I%d has invalid length", len)); + break; } break; diff --git a/src/lib/gui/KeySequence.cpp b/src/lib/gui/KeySequence.cpp index 6ce3b47a5..56315b588 100644 --- a/src/lib/gui/KeySequence.cpp +++ b/src/lib/gui/KeySequence.cpp @@ -163,6 +163,9 @@ QString KeySequence::keyToString(int key) return "2"; case Qt::MiddleButton: return "3"; + default: + qDebug() << "unknown key" << key; + break; } return "4"; // qt only knows three mouse buttons, so assume it's an unknown diff --git a/src/lib/gui/ScreenSetupModel.cpp b/src/lib/gui/ScreenSetupModel.cpp index d156402cb..6954a770a 100644 --- a/src/lib/gui/ScreenSetupModel.cpp +++ b/src/lib/gui/ScreenSetupModel.cpp @@ -57,6 +57,9 @@ QVariant ScreenSetupModel::data(const QModelIndex &index, int role) const case Qt::DisplayRole: return screen(index).name(); + + default: + break; } return QVariant(); } diff --git a/src/lib/platform/XWindowsScreen.cpp b/src/lib/platform/XWindowsScreen.cpp index 9fe76f19d..2aa6f060b 100644 --- a/src/lib/platform/XWindowsScreen.cpp +++ b/src/lib/platform/XWindowsScreen.cpp @@ -1333,6 +1333,9 @@ void XWindowsScreen::handleSystemEvent(const Event &event) LOG((CLOG_INFO "group change: %d", xkbEvent->state.group)); m_keyState->setActiveGroup((int32_t)xkbEvent->state.group); return; + + default: + return; } } #endif diff --git a/src/lib/platform/XWindowsScreenSaver.cpp b/src/lib/platform/XWindowsScreenSaver.cpp index 1f93b8ea6..937dd6a26 100644 --- a/src/lib/platform/XWindowsScreenSaver.cpp +++ b/src/lib/platform/XWindowsScreenSaver.cpp @@ -160,6 +160,8 @@ bool XWindowsScreenSaver::handleXEvent(const XEvent *xevent) return true; } break; + default: + break; } return false; diff --git a/src/lib/server/ClientProxyUnknown.cpp b/src/lib/server/ClientProxyUnknown.cpp index a0bbc1071..d32d0789b 100644 --- a/src/lib/server/ClientProxyUnknown.cpp +++ b/src/lib/server/ClientProxyUnknown.cpp @@ -181,6 +181,9 @@ void ClientProxyUnknown::initProxy(const std::string &name, int major, int minor case 8: m_proxy = new ClientProxy1_8(name, m_stream, m_server, m_events); break; + + default: + break; } }