From 3270b40455145be47fa5816ffe41e9cff0e847e9 Mon Sep 17 00:00:00 2001
From: sithlord48 <sithlord48@gmail.com>
Date: Tue, 30 Sep 2025 16:52:53 -0400
Subject: [PATCH] refactor: App, remove args from static startup methods to
 make StartupFunc no longer take args

---
 src/lib/deskflow/App.h                    |  1 +
 src/lib/deskflow/ClientApp.cpp            |  6 +++---
 src/lib/deskflow/IApp.h                   |  2 +-
 src/lib/deskflow/ServerApp.cpp            |  6 +++---
 src/lib/deskflow/unix/AppUtilUnix.cpp     |  2 +-
 src/lib/deskflow/win32/AppUtilWindows.cpp | 12 ++++++------
 src/lib/deskflow/win32/AppUtilWindows.h   |  4 ++--
 7 files changed, 17 insertions(+), 16 deletions(-)

diff --git a/src/lib/deskflow/App.h b/src/lib/deskflow/App.h
index ba233ebc1..81c3a3d88 100644
--- a/src/lib/deskflow/App.h
+++ b/src/lib/deskflow/App.h
@@ -77,6 +77,7 @@ public:
 
   int run(int argc, char **argv);
   int daemonMainLoop(int, const char **);
+
   void setupFileLogging();
   void loggingFilterWarning() const;
   void initApp() override;
diff --git a/src/lib/deskflow/ClientApp.cpp b/src/lib/deskflow/ClientApp.cpp
index ee8bab9fa..6c875ff21 100644
--- a/src/lib/deskflow/ClientApp.cpp
+++ b/src/lib/deskflow/ClientApp.cpp
@@ -354,9 +354,9 @@ int ClientApp::mainLoop()
   return s_exitSuccess;
 }
 
-static int daemonMainLoopStatic(int argc, const char **argv)
+static int daemonMainLoopStatic()
 {
-  return ClientApp::instance().daemonMainLoop(argc, argv);
+  return ClientApp::instance().daemonMainLoop(0, nullptr);
 }
 
 int ClientApp::start()
@@ -373,7 +373,7 @@ int ClientApp::runInner(int argc, char **argv, StartupFunc startup)
   int result;
   try {
     // run
-    result = startup(argc, argv);
+    result = startup();
   } catch (...) {
     delete m_serverAddress;
 
diff --git a/src/lib/deskflow/IApp.h b/src/lib/deskflow/IApp.h
index 511734756..1ec334ff8 100644
--- a/src/lib/deskflow/IApp.h
+++ b/src/lib/deskflow/IApp.h
@@ -8,7 +8,7 @@
 
 #pragma once
 
-using StartupFunc = int (*)(int, char **);
+using StartupFunc = int (*)();
 
 namespace deskflow {
 class Screen;
diff --git a/src/lib/deskflow/ServerApp.cpp b/src/lib/deskflow/ServerApp.cpp
index ccc52f157..45794807f 100644
--- a/src/lib/deskflow/ServerApp.cpp
+++ b/src/lib/deskflow/ServerApp.cpp
@@ -616,15 +616,15 @@ int ServerApp::runInner(int argc, char **argv, StartupFunc startup)
   m_config = std::make_shared<Config>(getEvents());
 
   // run
-  int result = startup(argc, argv);
+  int result = startup();
 
   delete m_deskflowAddress;
   return result;
 }
 
-int daemonMainLoopStatic(int argc, const char **argv)
+int daemonMainLoopStatic()
 {
-  return ServerApp::instance().daemonMainLoop(argc, argv);
+  return ServerApp::instance().daemonMainLoop(0, nullptr);
 }
 
 int ServerApp::start()
diff --git a/src/lib/deskflow/unix/AppUtilUnix.cpp b/src/lib/deskflow/unix/AppUtilUnix.cpp
index 061e694ec..b3e87892a 100644
--- a/src/lib/deskflow/unix/AppUtilUnix.cpp
+++ b/src/lib/deskflow/unix/AppUtilUnix.cpp
@@ -26,7 +26,7 @@ AppUtilUnix::AppUtilUnix(const IEventQueue *)
   // do nothing
 }
 
-int startStatic(int argc, char **argv)
+int startStatic()
 {
   return AppUtil::instance().app().start();
 }
diff --git a/src/lib/deskflow/win32/AppUtilWindows.cpp b/src/lib/deskflow/win32/AppUtilWindows.cpp
index bc4fdb54d..a90f44a0d 100644
--- a/src/lib/deskflow/win32/AppUtilWindows.cpp
+++ b/src/lib/deskflow/win32/AppUtilWindows.cpp
@@ -60,7 +60,7 @@ static int mainLoopStatic()
   return AppUtil::instance().app().mainLoop();
 }
 
-int AppUtilWindows::daemonNTMainLoop(int argc, const char **argv)
+int AppUtilWindows::daemonNTMainLoop()
 {
   app().initApp();
 
@@ -80,21 +80,21 @@ void AppUtilWindows::exitApp(int code)
   }
 }
 
-int daemonNTMainLoopStatic(int argc, const char **argv)
+int daemonNTMainLoopStatic()
 {
-  return AppUtilWindows::instance().daemonNTMainLoop(argc, argv);
+  return AppUtilWindows::instance().daemonNTMainLoop();
 }
 
-int AppUtilWindows::daemonNTStartup(int, char **)
+int AppUtilWindows::daemonNTStartup()
 {
   SystemLogger sysLogger(app().daemonName(), false);
   m_exitMode = kExitModeDaemon;
   return ARCH->daemonize(app().daemonName(), daemonNTMainLoopStatic);
 }
 
-static int daemonNTStartupStatic(int argc, char **argv)
+static int daemonNTStartupStatic()
 {
-  return AppUtilWindows::instance().daemonNTStartup(argc, argv);
+  return AppUtilWindows::instance().daemonNTStartup();
 }
 
 static int foregroundStartupStatic(int argc, char **argv)
diff --git a/src/lib/deskflow/win32/AppUtilWindows.h b/src/lib/deskflow/win32/AppUtilWindows.h
index 030118928..90b755fe0 100644
--- a/src/lib/deskflow/win32/AppUtilWindows.h
+++ b/src/lib/deskflow/win32/AppUtilWindows.h
@@ -34,8 +34,8 @@ public:
 
   static AppUtilWindows &instance();
 
-  int daemonNTStartup(int, char **);
-  int daemonNTMainLoop(int argc, const char **argv);
+  int daemonNTStartup();
+  int daemonNTMainLoop();
   int run(int argc, char **argv) override;
   void exitApp(int code) override;
   void startNode() override;