From 2d62e97e33aadbaa8c8f4d7823f0162863c38fe3 Mon Sep 17 00:00:00 2001
From: Nick Bolton <nick@symless.com>
Date: Wed, 4 Sep 2024 17:24:03 +0100
Subject: [PATCH] Don't return master as version

---
 scripts/lib/env.py | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/scripts/lib/env.py b/scripts/lib/env.py
index 2bd53b9db..26ba90c50 100644
--- a/scripts/lib/env.py
+++ b/scripts/lib/env.py
@@ -237,7 +237,10 @@ def get_app_version():
     Returns the version either from the env var, or from the version file.
     """
     version = get_env("SYNERGY_VERSION", required=False)
-    if version:
+
+    # TODO: Perhaps regex match the version string and if it's not a valid version,
+    # log a warning and fall back to the VERSION file value.
+    if version and version != "master":
         return version
 
     with open("VERSION", "r") as f: