From 2c433eddd773df036603c10fe06445310d04e8bb Mon Sep 17 00:00:00 2001
From: Nick Bolton <nick@symless.com>
Date: Tue, 4 Mar 2025 11:34:50 +0000
Subject: [PATCH] chore(daemon): Make function const and better string compare

- Make `clearSettings` const in daemon app
- Improve readability of empty command check
---
 src/lib/deskflow/DaemonApp.cpp | 4 ++--
 src/lib/deskflow/DaemonApp.h   | 2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/src/lib/deskflow/DaemonApp.cpp b/src/lib/deskflow/DaemonApp.cpp
index 66760bdc5..98be6f125 100644
--- a/src/lib/deskflow/DaemonApp.cpp
+++ b/src/lib/deskflow/DaemonApp.cpp
@@ -135,7 +135,7 @@ void DaemonApp::clearWatchdogCommand()
 #endif
 }
 
-void DaemonApp::clearSettings()
+void DaemonApp::clearSettings() const
 {
   LOG_INFO("clearing daemon settings");
   ARCH->clearSettings();
@@ -228,7 +228,7 @@ void DaemonApp::mainLoop()
 
     std::string command = ARCH->setting("Command");
     bool elevate = ARCH->setting("Elevate") == "1";
-    if (command != "") {
+    if (!command.empty()) {
       LOG_DEBUG("using last known command: %s", command.c_str());
       m_watchdog->setProcessConfig(command, elevate);
     }
diff --git a/src/lib/deskflow/DaemonApp.h b/src/lib/deskflow/DaemonApp.h
index 850087989..d84b8ba97 100644
--- a/src/lib/deskflow/DaemonApp.h
+++ b/src/lib/deskflow/DaemonApp.h
@@ -52,7 +52,7 @@ public:
   void setCommand(const QString &command);
   void applyWatchdogCommand() const;
   void clearWatchdogCommand();
-  void clearSettings();
+  void clearSettings() const;
   std::string logFilename();
 
   static DaemonApp &instance()