From 189053697b2f319fa8fec2bd38b75a18ffef3c23 Mon Sep 17 00:00:00 2001 From: Nick Bolton Date: Fri, 12 Sep 2025 11:05:20 +0100 Subject: [PATCH] refactor: Log server response on version check error Qt `errorString()` only contains the error code and error text, but not the response body. And, in HTTP/2 the error string is gone but the error is still printed like it's there: https://bugreports.qt.io/browse/QTBUG-140126 --- src/lib/gui/VersionChecker.cpp | 1 + 1 file changed, 1 insertion(+) diff --git a/src/lib/gui/VersionChecker.cpp b/src/lib/gui/VersionChecker.cpp index 807b902ed..1dbcf6cdf 100644 --- a/src/lib/gui/VersionChecker.cpp +++ b/src/lib/gui/VersionChecker.cpp @@ -39,6 +39,7 @@ void VersionChecker::replyFinished(QNetworkReply *reply) const auto httpStatus = reply->attribute(QNetworkRequest::HttpStatusCodeAttribute).toInt(); if (reply->error() != QNetworkReply::NoError) { qWarning("version check server error: %s", qPrintable(reply->errorString())); + qWarning("version check server response: %s", qPrintable(QString(reply->readAll()))); qWarning("error checking for updates, http status: %d", httpStatus); return; }