From 118f867fd1930dec2d2444f3a9b2a766e15ca8a2 Mon Sep 17 00:00:00 2001 From: sithlord48 Date: Thu, 1 May 2025 20:32:26 -0400 Subject: [PATCH] refactor: Remove unused IEventQueue::getRegisteredType() ported from https://github.com/input-leap/input-leap/pull/1545/commits/a5b6017235831dfc4703e13617e213bb0aa0c929 --- src/lib/base/EventQueue.cpp | 10 ---------- src/lib/base/EventQueue.h | 2 -- src/lib/base/IEventQueue.h | 6 ------ src/test/mock/deskflow/MockEventQueue.h | 1 - 4 files changed, 19 deletions(-) diff --git a/src/lib/base/EventQueue.cpp b/src/lib/base/EventQueue.cpp index 967284f1d..be470b8a1 100644 --- a/src/lib/base/EventQueue.cpp +++ b/src/lib/base/EventQueue.cpp @@ -115,7 +115,6 @@ Event::Type EventQueue::registerTypeOnce(Event::Type &type, const char *name) ArchMutexLock lock(m_mutex); if (type == Event::kUnknown) { m_typeMap.insert(std::make_pair(m_nextType, name)); - m_nameMap.insert(std::make_pair(name, m_nextType)); LOG((CLOG_DEBUG1 "registered event type %s as %d", name, m_nextType)); type = m_nextType++; } @@ -490,15 +489,6 @@ double EventQueue::getNextTimerTimeout() const return m_timerQueue.top(); } -Event::Type EventQueue::getRegisteredType(const std::string &name) const -{ - NameMap::const_iterator found = m_nameMap.find(name); - if (found != m_nameMap.end()) - return found->second; - - return Event::kUnknown; -} - void *EventQueue::getSystemTarget() { // any unique arbitrary pointer will do diff --git a/src/lib/base/EventQueue.h b/src/lib/base/EventQueue.h index de50cf0b6..9f001d7f8 100644 --- a/src/lib/base/EventQueue.h +++ b/src/lib/base/EventQueue.h @@ -50,7 +50,6 @@ public: bool isEmpty() const override; IEventJob *getHandler(Event::Type type, void *target) const override; const char *getTypeName(Event::Type type) override; - Event::Type getRegisteredType(const std::string &name) const override; void *getSystemTarget() override; void waitForReady() const override; @@ -104,7 +103,6 @@ private: // registered events Event::Type m_nextType; TypeMap m_typeMap; - NameMap m_nameMap; // buffer of events IEventQueueBuffer *m_buffer; diff --git a/src/lib/base/IEventQueue.h b/src/lib/base/IEventQueue.h index 3a3a2d149..3aabbe7d5 100644 --- a/src/lib/base/IEventQueue.h +++ b/src/lib/base/IEventQueue.h @@ -192,12 +192,6 @@ public: */ virtual const char *getTypeName(Event::Type type) = 0; - //! Get an event type by name - /*! - Returns the registered type for an event for a given name. - */ - virtual Event::Type getRegisteredType(const std::string &name) const = 0; - //! Get the system event type target /*! Returns the target to use for dispatching \c Event::kSystem events. diff --git a/src/test/mock/deskflow/MockEventQueue.h b/src/test/mock/deskflow/MockEventQueue.h index 864821db6..e3faf253d 100644 --- a/src/test/mock/deskflow/MockEventQueue.h +++ b/src/test/mock/deskflow/MockEventQueue.h @@ -30,7 +30,6 @@ public: MOCK_METHOD(bool, dispatchEvent, (const Event &), (override)); MOCK_METHOD(IEventJob *, getHandler, (Event::Type, void *), (const, override)); MOCK_METHOD(void, deleteTimer, (EventQueueTimer *), (override)); - MOCK_METHOD(Event::Type, getRegisteredType, (const std::string &), (const, override)); MOCK_METHOD(void *, getSystemTarget, (), (override)); MOCK_METHOD(ClientEvents &, forClient, (), (override)); MOCK_METHOD(IStreamEvents &, forIStream, (), (override));