From 0d5d66b880eb03c5575360ea7af24a8386525fa1 Mon Sep 17 00:00:00 2001 From: sithlord48 Date: Sat, 22 Nov 2025 12:26:21 -0500 Subject: [PATCH] chore: remove unused Settings::tlsLocalDb we no longer use the local fingerprint file --- src/lib/common/Constants.h.in | 1 - src/lib/common/Settings.cpp | 5 ----- src/lib/common/Settings.h | 1 - src/unittests/common/SettingsTests.cpp | 5 ----- src/unittests/common/SettingsTests.h | 3 --- 5 files changed, 15 deletions(-) diff --git a/src/lib/common/Constants.h.in b/src/lib/common/Constants.h.in index c250de8d5..2c96a89bb 100644 --- a/src/lib/common/Constants.h.in +++ b/src/lib/common/Constants.h.in @@ -26,7 +26,6 @@ const auto kCoreBinName = "@CORE_BINARY@"; const auto kTlsDirName = "tls"; const auto kTlsCertificateFilename = "@CMAKE_PROJECT_NAME@.pem"; -const auto kTlsFingerprintLocalFilename = "local-fingerprint"; const auto kTlsFingerprintTrustedServersFilename = "trusted-servers"; const auto kTlsFingerprintTrustedClientsFilename = "trusted-clients"; diff --git a/src/lib/common/Settings.cpp b/src/lib/common/Settings.cpp index 66fdd8443..c0adc1e90 100644 --- a/src/lib/common/Settings.cpp +++ b/src/lib/common/Settings.cpp @@ -286,11 +286,6 @@ QString Settings::tlsDir() return QStringLiteral("%1/%2").arg(instance()->settingsPath(), kTlsDirName); } -QString Settings::tlsLocalDb() -{ - return QStringLiteral("%1/%2").arg(instance()->tlsDir(), kTlsFingerprintLocalFilename); -} - QString Settings::tlsTrustedServersDb() { return QStringLiteral("%1/%2").arg(instance()->tlsDir(), kTlsFingerprintTrustedServersFilename); diff --git a/src/lib/common/Settings.h b/src/lib/common/Settings.h index e816b69a6..4431410e1 100644 --- a/src/lib/common/Settings.h +++ b/src/lib/common/Settings.h @@ -128,7 +128,6 @@ public: static QString settingsFile(); static QString settingsPath(); static QString tlsDir(); - static QString tlsLocalDb(); static QString tlsTrustedServersDb(); static QString tlsTrustedClientsDb(); static QString logLevelText(); diff --git a/src/unittests/common/SettingsTests.cpp b/src/unittests/common/SettingsTests.cpp index f2c5a3167..42af8e56f 100644 --- a/src/unittests/common/SettingsTests.cpp +++ b/src/unittests/common/SettingsTests.cpp @@ -41,11 +41,6 @@ void SettingsTests::tlsDir() QVERIFY(Settings::tlsDir().endsWith(m_expectedTlsDir)); } -void SettingsTests::tlsLocalDb() -{ - QVERIFY(Settings::tlsLocalDb().endsWith(m_expectedTlsLocalDB)); -} - void SettingsTests::tlsTrustedServersDb() { QVERIFY(Settings::tlsTrustedServersDb().endsWith(m_expectedTlsServerDB)); diff --git a/src/unittests/common/SettingsTests.h b/src/unittests/common/SettingsTests.h index 72fd401ac..6f3f18695 100644 --- a/src/unittests/common/SettingsTests.h +++ b/src/unittests/common/SettingsTests.h @@ -19,7 +19,6 @@ private Q_SLOTS: void settingsFile(); void settingsPath(); void tlsDir(); - void tlsLocalDb(); void tlsTrustedServersDb(); void tlsTrustedClientsDb(); void checkValidSettings(); @@ -40,8 +39,6 @@ private: #endif inline static const QString m_expectedTlsDir = QStringLiteral("%1/%2").arg(m_settingsPath, kTlsDirName); - inline static const QString m_expectedTlsLocalDB = - QStringLiteral("%1/%2").arg(m_expectedTlsDir, kTlsFingerprintLocalFilename); inline static const QString m_expectedTlsServerDB = QStringLiteral("%1/%2").arg(m_expectedTlsDir, kTlsFingerprintTrustedServersFilename); inline static const QString m_expectedTlsClientDB =