From 09d4b1a27a425d764665ae251d2e48e50d9f15e3 Mon Sep 17 00:00:00 2001
From: sithlord48 <sithlord48@gmail.com>
Date: Mon, 23 Feb 2026 22:13:33 -0500
Subject: [PATCH] refactor: Forward Declare more in gui/validators classes

---
 src/lib/gui/validators/AliasValidator.cpp              | 2 ++
 src/lib/gui/validators/AliasValidator.h                | 2 +-
 src/lib/gui/validators/IpAddressValidator.cpp          | 1 +
 src/lib/gui/validators/IpAddressValidator.h            | 1 -
 src/lib/gui/validators/LineEditValidator.cpp           | 2 ++
 src/lib/gui/validators/LineEditValidator.h             | 5 ++---
 src/lib/gui/validators/ScreenDuplicationsValidator.cpp | 1 +
 src/lib/gui/validators/ScreenDuplicationsValidator.h   | 2 +-
 src/lib/gui/validators/ScreenNameValidator.cpp         | 3 +++
 src/lib/gui/validators/ScreenNameValidator.h           | 4 ++--
 src/lib/gui/validators/ValidationError.cpp             | 1 +
 src/lib/gui/validators/ValidationError.h               | 3 ++-
 12 files changed, 18 insertions(+), 9 deletions(-)

diff --git a/src/lib/gui/validators/AliasValidator.cpp b/src/lib/gui/validators/AliasValidator.cpp
index 270d43481..7f59bc9bf 100644
--- a/src/lib/gui/validators/AliasValidator.cpp
+++ b/src/lib/gui/validators/AliasValidator.cpp
@@ -9,7 +9,9 @@
 #include "ComputerNameValidator.h"
 #include "IpAddressValidator.h"
 #include "SpacesValidator.h"
+#include "ValidationError.h"
 
+#include <QLineEdit>
 #include <QRegularExpression>
 
 namespace validators {
diff --git a/src/lib/gui/validators/AliasValidator.h b/src/lib/gui/validators/AliasValidator.h
index ec88332b8..10c087e9b 100644
--- a/src/lib/gui/validators/AliasValidator.h
+++ b/src/lib/gui/validators/AliasValidator.h
@@ -7,9 +7,9 @@
 #pragma once
 
 #include "LineEditValidator.h"
-#include "ValidationError.h"
 
 namespace validators {
+class ValidationError;
 
 class AliasValidator : public LineEditValidator
 {
diff --git a/src/lib/gui/validators/IpAddressValidator.cpp b/src/lib/gui/validators/IpAddressValidator.cpp
index 5fdf38a48..327c50311 100644
--- a/src/lib/gui/validators/IpAddressValidator.cpp
+++ b/src/lib/gui/validators/IpAddressValidator.cpp
@@ -5,6 +5,7 @@
  */
 
 #include "IpAddressValidator.h"
+#include <QRegularExpression>
 
 namespace validators {
 
diff --git a/src/lib/gui/validators/IpAddressValidator.h b/src/lib/gui/validators/IpAddressValidator.h
index 28bc87fd8..8ce8ade88 100644
--- a/src/lib/gui/validators/IpAddressValidator.h
+++ b/src/lib/gui/validators/IpAddressValidator.h
@@ -7,7 +7,6 @@
 #pragma once
 
 #include "IStringValidator.h"
-#include <QRegularExpression>
 
 namespace validators {
 
diff --git a/src/lib/gui/validators/LineEditValidator.cpp b/src/lib/gui/validators/LineEditValidator.cpp
index 989c44806..c4278df2f 100644
--- a/src/lib/gui/validators/LineEditValidator.cpp
+++ b/src/lib/gui/validators/LineEditValidator.cpp
@@ -6,8 +6,10 @@
  */
 
 #include "LineEditValidator.h"
+#include "ValidationError.h"
 
 #include <QApplication>
+#include <QLineEdit>
 #include <QStyle>
 #include <QValidator>
 
diff --git a/src/lib/gui/validators/LineEditValidator.h b/src/lib/gui/validators/LineEditValidator.h
index 9b1c2bf08..4202ddc15 100644
--- a/src/lib/gui/validators/LineEditValidator.h
+++ b/src/lib/gui/validators/LineEditValidator.h
@@ -8,15 +8,14 @@
 
 #include "IStringValidator.h"
 
-#include <QLabel>
-#include <QLineEdit>
 #include <QValidator>
 #include <memory>
 #include <vector>
 
-#include "ValidationError.h"
+class QLineEdit;
 
 namespace validators {
+class ValidationError;
 
 class LineEditValidator : public QValidator
 {
diff --git a/src/lib/gui/validators/ScreenDuplicationsValidator.cpp b/src/lib/gui/validators/ScreenDuplicationsValidator.cpp
index c3a71cbad..6126fc402 100644
--- a/src/lib/gui/validators/ScreenDuplicationsValidator.cpp
+++ b/src/lib/gui/validators/ScreenDuplicationsValidator.cpp
@@ -5,6 +5,7 @@
  */
 
 #include "ScreenDuplicationsValidator.h"
+#include "gui/config/ScreenList.h"
 
 namespace validators {
 
diff --git a/src/lib/gui/validators/ScreenDuplicationsValidator.h b/src/lib/gui/validators/ScreenDuplicationsValidator.h
index da897f486..b0c671f7c 100644
--- a/src/lib/gui/validators/ScreenDuplicationsValidator.h
+++ b/src/lib/gui/validators/ScreenDuplicationsValidator.h
@@ -8,7 +8,7 @@
 
 #include "IStringValidator.h"
 
-#include "gui/config/ScreenList.h"
+class ScreenList;
 
 namespace validators {
 
diff --git a/src/lib/gui/validators/ScreenNameValidator.cpp b/src/lib/gui/validators/ScreenNameValidator.cpp
index dbee2552b..042cba49c 100644
--- a/src/lib/gui/validators/ScreenNameValidator.cpp
+++ b/src/lib/gui/validators/ScreenNameValidator.cpp
@@ -12,6 +12,9 @@
 #include "SpacesValidator.h"
 #include "ValidationError.h"
 
+#include "gui/config/ScreenList.h"
+
+#include <QLineEdit>
 #include <QRegularExpression>
 #include <memory>
 
diff --git a/src/lib/gui/validators/ScreenNameValidator.h b/src/lib/gui/validators/ScreenNameValidator.h
index 9b1e64c8a..9d0f33ebe 100644
--- a/src/lib/gui/validators/ScreenNameValidator.h
+++ b/src/lib/gui/validators/ScreenNameValidator.h
@@ -7,11 +7,11 @@
 #pragma once
 
 #include "LineEditValidator.h"
-#include "ValidationError.h"
 
-#include "gui/config/ScreenList.h"
+class ScreenList;
 
 namespace validators {
+class ValidationError;
 
 class ScreenNameValidator : public LineEditValidator
 {
diff --git a/src/lib/gui/validators/ValidationError.cpp b/src/lib/gui/validators/ValidationError.cpp
index 5acffc08e..c9ce79133 100644
--- a/src/lib/gui/validators/ValidationError.cpp
+++ b/src/lib/gui/validators/ValidationError.cpp
@@ -7,6 +7,7 @@
 
 #include "ValidationError.h"
 
+#include <QLabel>
 #include <QPalette>
 
 namespace validators {
diff --git a/src/lib/gui/validators/ValidationError.h b/src/lib/gui/validators/ValidationError.h
index 3d049a2ad..4425d60a9 100644
--- a/src/lib/gui/validators/ValidationError.h
+++ b/src/lib/gui/validators/ValidationError.h
@@ -7,10 +7,11 @@
 
 #pragma once
 
-#include <QLabel>
 #include <QObject>
 #include <QString>
 
+class QLabel;
+
 namespace validators {
 
 class ValidationError : public QObject