From 023e8dc78eeed33edd2e6cf5639fdb41e7c5085b Mon Sep 17 00:00:00 2001 From: sithlord48 Date: Sat, 25 Oct 2025 19:20:10 -0400 Subject: [PATCH] chore: remove unused ARCH->showLog --- src/lib/arch/IArchLog.h | 9 --------- src/lib/arch/unix/ArchLogUnix.cpp | 5 ----- src/lib/arch/unix/ArchLogUnix.h | 1 - src/lib/arch/win32/ArchLogWindows.cpp | 5 ----- src/lib/arch/win32/ArchLogWindows.h | 1 - src/lib/base/LogOutputters.cpp | 2 +- 6 files changed, 1 insertion(+), 22 deletions(-) diff --git a/src/lib/arch/IArchLog.h b/src/lib/arch/IArchLog.h index 1ed0b8c43..fc01496d8 100644 --- a/src/lib/arch/IArchLog.h +++ b/src/lib/arch/IArchLog.h @@ -37,15 +37,6 @@ public: */ virtual void closeLog() = 0; - //! Show the log - /*! - Causes the log to become visible. This generally only makes sense - for a log in a graphical user interface. Other implementations - will do nothing. Iff \p showIfEmpty is \c false then the implementation - may optionally only show the log if it's not empty. - */ - virtual void showLog(bool showIfEmpty) = 0; - //! Write to the log /*! Writes the given string to the log with the given level. diff --git a/src/lib/arch/unix/ArchLogUnix.cpp b/src/lib/arch/unix/ArchLogUnix.cpp index 1bab435df..b93a65149 100644 --- a/src/lib/arch/unix/ArchLogUnix.cpp +++ b/src/lib/arch/unix/ArchLogUnix.cpp @@ -23,11 +23,6 @@ void ArchLogUnix::closeLog() closelog(); } -void ArchLogUnix::showLog(bool) -{ - // do nothing -} - void ArchLogUnix::writeLog(LogLevel level, const QString &msg) { // convert level diff --git a/src/lib/arch/unix/ArchLogUnix.h b/src/lib/arch/unix/ArchLogUnix.h index c8459638a..f870861db 100644 --- a/src/lib/arch/unix/ArchLogUnix.h +++ b/src/lib/arch/unix/ArchLogUnix.h @@ -21,6 +21,5 @@ public: // IArchLog overrides void openLog(const QString &name) override; void closeLog() override; - void showLog(bool) override; void writeLog(LogLevel, const QString &) override; }; diff --git a/src/lib/arch/win32/ArchLogWindows.cpp b/src/lib/arch/win32/ArchLogWindows.cpp index c1bc72a72..cbef391fd 100644 --- a/src/lib/arch/win32/ArchLogWindows.cpp +++ b/src/lib/arch/win32/ArchLogWindows.cpp @@ -33,11 +33,6 @@ void ArchLogWindows::closeLog() } } -void ArchLogWindows::showLog(bool) -{ - // do nothing -} - void ArchLogWindows::writeLog(LogLevel level, const QString &msg) { if (m_eventLog != nullptr) { diff --git a/src/lib/arch/win32/ArchLogWindows.h b/src/lib/arch/win32/ArchLogWindows.h index 3468f7afe..ff2c226d5 100644 --- a/src/lib/arch/win32/ArchLogWindows.h +++ b/src/lib/arch/win32/ArchLogWindows.h @@ -24,7 +24,6 @@ public: // IArchLog overrides void openLog(const QString &name) override; void closeLog() override; - void showLog(bool showIfEmpty) override; void writeLog(LogLevel, const QString &) override; private: diff --git a/src/lib/base/LogOutputters.cpp b/src/lib/base/LogOutputters.cpp index 4261d6eaa..6460c8032 100644 --- a/src/lib/base/LogOutputters.cpp +++ b/src/lib/base/LogOutputters.cpp @@ -91,7 +91,7 @@ void SystemLogOutputter::close() void SystemLogOutputter::show(bool showIfEmpty) { - ARCH->showLog(showIfEmpty); + // do nothing } bool SystemLogOutputter::write(LogLevel level, const QString &msg)