From 004089f8872b68851a9cb3503bb65b7b375195ca Mon Sep 17 00:00:00 2001 From: sithlord48 Date: Fri, 10 Oct 2025 16:31:28 -0400 Subject: [PATCH] refactor: Coreprocess remove single use one liner persistLogDir, make dir in start if needed --- src/lib/gui/core/CoreProcess.cpp | 8 ++------ src/lib/gui/core/CoreProcess.h | 2 +- 2 files changed, 3 insertions(+), 7 deletions(-) diff --git a/src/lib/gui/core/CoreProcess.cpp b/src/lib/gui/core/CoreProcess.cpp index 793f1153a..ce5342816 100644 --- a/src/lib/gui/core/CoreProcess.cpp +++ b/src/lib/gui/core/CoreProcess.cpp @@ -1,5 +1,6 @@ /* * Deskflow -- mouse and keyboard sharing utility + * SPDX-FileCopyrightText: (C) 2025 Chris Rizzitello * SPDX-FileCopyrightText: (C) 2024 - 2025 Symless Ltd. * SPDX-License-Identifier: GPL-2.0-only WITH LicenseRef-OpenSSL-Exception */ @@ -347,8 +348,8 @@ void CoreProcess::start(std::optional processModeOption) qDebug().noquote() << "log level:" << Settings::logLevelText(); if (Settings::value(Settings::Log::ToFile).toBool()) { - persistLogDir(); const auto logFile = Settings::value(Settings::Log::File).toString(); + QDir(QFileInfo(logFile).absolutePath()).mkpath("."); args.append({QStringLiteral("--log"), logFile}); qInfo().noquote() << "log file:" << logFile; } @@ -550,11 +551,6 @@ QString CoreProcess::requestDaemonLogPath() return logPath; } -void CoreProcess::persistLogDir() const -{ - QDir(QFileInfo(Settings::value(Settings::Log::File).toString()).absolutePath()).mkpath("."); -} - void CoreProcess::clearSettings() { const auto processMode = Settings::value(Settings::Core::ProcessMode).value(); diff --git a/src/lib/gui/core/CoreProcess.h b/src/lib/gui/core/CoreProcess.h index 31da7ad0b..561a5f8b6 100644 --- a/src/lib/gui/core/CoreProcess.h +++ b/src/lib/gui/core/CoreProcess.h @@ -1,5 +1,6 @@ /* * Deskflow -- mouse and keyboard sharing utility + * SPDX-FileCopyrightText: (C) 2025 Chris Rizzitello * SPDX-FileCopyrightText: (C) 2024 - 2025 Symless Ltd. * SPDX-License-Identifier: GPL-2.0-only WITH LicenseRef-OpenSSL-Exception */ @@ -125,7 +126,6 @@ private: void handleLogLines(const QString &text); QString correctedAddress() const; QString requestDaemonLogPath(); - void persistLogDir() const; static QString makeQuotedArgs(const QString &app, const QStringList &args); static QString processModeToString(const Settings::ProcessMode mode); static QString processStateToString(const CoreProcess::ProcessState state);